fix: Actions on gump crash when Runebook has no entries (#1964) #5961
5595 new problems found by Qodana for .NET
Qodana for .NET
5595 new problems were found
| Inspection name | Severity | Problems |
|---|---|---|
Unused parameter (private accessibility) |
🔶 Warning | 173 |
Incorrect indent (incorrect indent size) |
🔶 Warning | 79 |
Incorrect indent (around declaration braces) |
🔶 Warning | 68 |
Heuristically unreachable code |
🔶 Warning | 57 |
Type member is never used (private accessibility) |
🔶 Warning | 52 |
Assignment in conditional expression |
🔶 Warning | 31 |
Parameter is only used for precondition check (private accessibility) |
🔶 Warning | 24 |
Possible unassigned object created by 'new' expression |
🔶 Warning | 20 |
Useless arithmetical operation |
🔶 Warning | 20 |
Replace 'switch' statement with 'switch' expression |
🔶 Warning | 15 |
Non-accessed field (private accessibility) |
🔶 Warning | 14 |
Incorrect indent (missing indent/outdent elsewhere) |
🔶 Warning | 11 |
Assignment is not used |
🔶 Warning | 11 |
Expression is always 'true' or always 'false' |
🔶 Warning | 10 |
Conditional access qualifier expression is known to be null or not null |
🔶 Warning | 10 |
Static field or auto-property in generic type |
🔶 Warning | 9 |
Return value of [MustUseReturnValue] annotated method is not used |
🔶 Warning | 8 |
Possible 'System.InvalidCastException' in foreach loop |
🔶 Warning | 8 |
Get-only auto-property is never assigned |
🔶 Warning | 8 |
Possible 'null' assignment to non-nullable entity |
🔶 Warning | 7 |
Method return value is never used (private accessibility) |
🔶 Warning | 7 |
Incorrect indent (around statement braces) |
🔶 Warning | 6 |
Member hides static member from outer class |
🔶 Warning | 5 |
Redundant argument with default value |
🔶 Warning | 5 |
Method with optional or 'params' parameter is hidden by overload |
🔶 Warning | 4 |
Redundant member override |
🔶 Warning | 4 |
Call to base member with implicit default parameters |
🔶 Warning | 3 |
The pattern is redundant, it does not produce any runtime checks |
🔶 Warning | 3 |
Type is never used (private accessibility) |
🔶 Warning | 3 |
Possible overflow in unchecked context |
🔶 Warning | 2 |
Non-accessed local variable |
🔶 Warning | 2 |
Redundant 'partial' modifier on type declaration |
🔶 Warning | 2 |
Possible unintended reference comparison |
🔶 Warning | 2 |
Possibly impure struct method is called on readonly variable: struct value always copied before invocation |
🔶 Warning | 2 |
Private field can be converted into local variable |
🔶 Warning | 2 |
Collection content is never queried (non-private accessibility) |
🔶 Warning | 1 |
Collection is never updated (non-private accessibility) |
🔶 Warning | 1 |
Use null check pattern instead of a type check succeeding on any not-null value |
🔶 Warning | 1 |
Possible loss of fraction |
🔶 Warning | 1 |
Redundant 'Attribute' suffix |
🔶 Warning | 1 |
Redundant base constructor call |
🔶 Warning | 1 |
Redundant 'case' label |
🔶 Warning | 1 |
Redundant catch clause |
🔶 Warning | 1 |
Redundant empty argument list on object creation expression |
🔶 Warning | 1 |
Redundant operand in logical conditional expression |
🔶 Warning | 1 |
Redundant name qualifier |
🔶 Warning | 1 |
Redundant type check in a pattern |
🔶 Warning | 1 |
Namespace does not correspond to file location |
◽️ Notice | 3359 |
Virtual member call in constructor |
◽️ Notice | 1261 |
Unused local variable |
◽️ Notice | 243 |
Specify string culture explicitly |
◽️ Notice | 19 |
Equality comparison of floating point numbers |
◽️ Notice | 14 |
💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report
Detected 20 dependencies
Third-party software list
This page lists the third-party software dependencies used in ModernUO
| Dependency | Version | Licenses |
|---|---|---|
| Argon2.Bindings | 1.16.1 | MIT |
| BouncyCastle.Cryptography | 2.4.0 | MIT |
| CommunityToolkit.HighPerformance | 8.3.2 | MIT |
| LibDeflate.Bindings | 1.0.2.120 | GPL-3.0-only |
| MailKit | 4.7.1.1 | MIT |
| Microsoft.Extensions.FileSystemGlobbing | 8.0.0 | MIT |
| MimeKit | 4.7.1 | MIT |
| ModernUO.CodeGeneratedEvents.Annotations | 1.0.0 | GPL-3.0-only |
| ModernUO.CodeGeneratedEvents.Generator | 1.0.3.2 | GPL-3.0-only |
| ModernUO.Serialization.Annotations | 2.9.1 | GPL-3.0-only |
| ModernUO.Serialization.Generator | 2.11.3 | GPL-3.0-only |
| Nerdbank.GitVersioning | 3.6.143 | MIT |
| PollGroup | 1.5.1 | BSD-3-Clause |
| Serilog.Sinks.Async | 2.0.0 | Apache-2.0 |
| Serilog.Sinks.Console | 6.0.0 | Apache-2.0 |
| Serilog | 4.0.1 | Apache-2.0 |
| System.Formats.Asn1 | 8.0.1 | MIT |
| System.IO.Hashing | 8.0.0 | MIT |
| System.Security.Cryptography.Pkcs | 8.0.0 | MIT |
| Zstd.Binaries | 1.6.0 | MIT |
Contact Qodana team
Contact us at qodana-support@jetbrains.com
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
Details
This result was published with Qodana GitHub Action
Annotations
Check warning on line 100 in Projects/Server/Json/Converters/Point2DConverter.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 87 in Projects/Server/Json/JsonConfig.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 140 in Projects/UOContent/Misc/ServerList.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 102 in Projects/Server/Json/Converters/Point3DConverter.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 176 in Projects/Server/Json/Converters/WorldLocationConverter.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 33 in Projects/UOContent/Mobiles/Hireables/HirePeasant.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 317 in Projects/UOContent/Mobiles/Townfolk/TownCrier.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 38 in Projects/UOContent/Mobiles/Hireables/HirePaladin.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 21 in Projects/UOContent/Mobiles/Townfolk/Gypsy.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 313 in Projects/UOContent/Mobiles/Townfolk/BaseEscortable.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 216 in Projects/UOContent/Mobiles/Vendors/PlayerVendor.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 18 in Projects/UOContent/Mobiles/Monsters/Humanoid/Melee/ElfBrigand.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 37 in Projects/UOContent/Mobiles/Hireables/HireFighter.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 19 in Projects/UOContent/Mobiles/Townfolk/Sculptor.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 15 in Projects/UOContent/Mobiles/Monsters/Humanoid/Melee/Savage.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 16 in Projects/UOContent/Mobiles/Monsters/Humanoid/Melee/Executioner.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 34 in Projects/UOContent/Mobiles/Hireables/HireBeggar.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 37 in Projects/UOContent/Mobiles/Hireables/HireRanger.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 25 in Projects/UOContent/Mobiles/Townfolk/Samurai.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 19 in Projects/UOContent/Mobiles/Monsters/Humanoid/Melee/Guardian.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 40 in Projects/UOContent/Mobiles/Hireables/HireSailor.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 20 in Projects/UOContent/Mobiles/Townfolk/HarborMaster.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?
Check warning on line 23 in Projects/UOContent/Mobiles/Guards/ArcherGuard.cs
github-actions / Qodana for .NET
Assignment in conditional expression
Assignment in conditional expression; did you mean to use '==' instead of '='?