-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rollup-plugin-import-meta-assets] Fix resolving and respect external
rollup option
#2819
base: master
Are you sure you want to change the base?
[rollup-plugin-import-meta-assets] Fix resolving and respect external
rollup option
#2819
Conversation
|
can you please add unit tests? |
be57128
to
1e29291
Compare
done! fixed the current test and added a new test |
Btw, I'm not sure about the "ignore if it's a directory" feature, I don't really see the point of it, and the user can now explicitely ignore it by setting it as external |
1e29291
to
f784376
Compare
Just fixed the tests for windows |
up? |
The plugin currently doesn't support:
path
tool)That PR implements that