Fix branch #16
Fix branch #16
Conversation
* Move error check, to happen before the value returned is used * (Temporarily) comment unused struct variables (should be either removed or used)
…hanges to new endpoints
Set STREAM_ENCODER environment variable to "SSE", to use SSE as stream encoder.
A BankID auth order is only valid for 30 seconds, unless the QR-code is scanned, then the order is valid for 180 seconds.
| @@ -113,7 +113,7 @@ func (a *API) Change(ctx context.Context, r *ChangeRequest) (*CollectResponse, e | |||
| } | |||
| } | |||
|
|
|||
| func (a *API) WatchForChange(ctx context.Context, orderRef string) chan WatchResponse { | |||
| func (a *API) WatchForChange(ctx context.Context, orderRef string) <-chan WatchResponse { | |||
| Err error | ||
| } | ||
|
|
||
| func (a *API) WatchForChangeV2(ctx context.Context, orderRef string) (<-chan Change, error) { |
There was a problem hiding this comment.
Should we perhaps name this something different to highlight their intended purposes?
There was a problem hiding this comment.
Maybe? My best suggestion were WatchForChanges, but I felt that it would be too like WatchForChange without clarifying the differences between them, so I just kept the V2 suffix so that (in my mind at least) it would be more obvious that it were related to the v2 endpoints, but it still performed a similar function as WatchForChange..
| return 0, nil, nil | ||
| } | ||
|
|
||
| // Handle messages that use 'CRLF' or 'LF' line endings. |
There was a problem hiding this comment.
Why do we need to handle CRLF endings?
There was a problem hiding this comment.
Well, if it's only used to read SSE messages from the writer in twofer, then we would not need to handle either CRLF or CR delimited messages. When I did the reader, I wanted it to follow the specification, so that it would be possible to use it to read SSE messages from other sources as well. This were when I intended to use SSE for the new v2 endpoints, before i discovered NDJSON. Since I already had everything in place for SSE, I kept it around in case it's simpler to use that in other languages, but if "caller" is using GO, it's simpler and much less code to use NDJSON, so I made NDJSON the default for the new v2 andpoints, but it's still possible to switch to SSE by setting an environment variable.
There was a problem hiding this comment.
Come to think about it now, maybe it would have been better to pass the intended delimiter as a parameter when creating the reader, that way the reader would not need the code that try to handle all possible line-endings.. Since when you are working with an SSE-stream, you would know what delimiter that particular stream uses as delimiter.
Contains a few fixes for various things, and also introduce two new endpoints for
authandsignthat have a slightly different API that return more information to caller.