Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pathline/endpoint plots): support recarray or dataframe #1888

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Aug 1, 2023

  • Accept single or list of recarray or dataframe inPlotMapView and PlotCrossSection particle track plotting methods
    • plot_pathline()
    • plot_timeseries()
    • plot_endpoint()
  • Update plot tests
  • Tidy doc strings

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1888 (27958f5) into develop (7931112) will decrease coverage by 1.8%.
Report is 2 commits behind head on develop.
The diff coverage is 94.7%.

@@            Coverage Diff            @@
##           develop   #1888     +/-   ##
=========================================
- Coverage     72.2%   70.5%   -1.8%     
=========================================
  Files          257     257             
  Lines        56508   56506      -2     
=========================================
- Hits         40841   39837   -1004     
- Misses       15667   16669   +1002     
Files Changed Coverage Δ
flopy/utils/utl_import.py 68.1% <ø> (ø)
flopy/utils/sfroutputfile.py 76.6% <75.0%> (+1.2%) ⬆️
flopy/export/metadata.py 23.3% <100.0%> (+0.8%) ⬆️
flopy/mf6/utils/binaryfile_utils.py 10.6% <100.0%> (+0.4%) ⬆️
flopy/mf6/utils/mfobservation.py 13.5% <100.0%> (+0.4%) ⬆️
flopy/modflow/mfsfr2.py 87.5% <100.0%> (+<0.1%) ⬆️
flopy/modpath/mp6sim.py 84.1% <100.0%> (ø)
flopy/plot/crosssection.py 66.9% <100.0%> (+0.5%) ⬆️
flopy/plot/map.py 84.0% <100.0%> (+<0.1%) ⬆️
flopy/utils/flopy_io.py 75.4% <100.0%> (ø)
... and 5 more

... and 55 files with indirect coverage changes

@wpbonelli wpbonelli marked this pull request as ready for review August 1, 2023 16:20
@wpbonelli wpbonelli requested a review from jlarsen-usgs August 1, 2023 16:20
@wpbonelli wpbonelli merged commit 54d6099 into modflowpy:develop Aug 1, 2023
@wpbonelli wpbonelli deleted the plot-tests branch August 1, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants