refactor(mf6): remove deprecated features #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* layer kwarg in get_data() in mfdataarray.py, 3.3.5 (June 2022) * get_mvr_file, get_mvt_file, get_gnc_file in mfsimbase.py, overdue since 3.3.6 * get_ims_package in mfsimbase.py (and update usage in mfmodel.py), overdue since 3.4
Codecov Report
@@ Coverage Diff @@
## develop #1894 +/- ##
=======================================
Coverage 72.2% 72.3%
=======================================
Files 257 257
Lines 56488 56464 -24
=======================================
- Hits 40836 40831 -5
+ Misses 15652 15633 -19
|
langevin-usgs
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_data()inmfdataarray.py, deprecated 3.3.5 (June 2022)get_mvr_file(),get_mvt_file(),get_gnc_file()inmfsimbase.py, removal overdue since 3.3.6get_ims_package()inmfsimbase.py, removal overdue since 3.4mfmodel.pyusage toget_solution_package()