fix(keyword data): optional keywords (#1909) #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flopy allows some keywords to be excluded from recarrays, like "FILEIN". This fix makes sure that optional keywords, like "MIXED" are not excluded from recarrays. Since they are optional their presence adds information to the recarray and they therefore can not be excluded.
Codecov Report
@@ Coverage Diff @@
## develop #1920 +/- ##
=========================================
- Coverage 72.6% 72.6% -0.1%
=========================================
Files 257 257
Lines 56210 56210
=========================================
- Hits 40835 40833 -2
- Misses 15375 15377 +2
|
wpbonelli
pushed a commit
that referenced
this pull request
Aug 25, 2023
Flopy allows some keywords to be excluded from recarrays, like "FILEIN". This fix makes sure that optional keywords, like "MIXED" are not excluded from recarrays. Since they are optional their presence adds information to the recarray and they therefore can not be excluded. Co-authored-by: scottrp <45947939+scottrp@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flopy allows some keywords to be excluded from recarrays, like "FILEIN". This fix makes sure that optional keywords, like "MIXED" are not excluded from recarrays. Since they are optional their presence adds information to the recarray and they therefore can not be excluded.