Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: support python3.12, simplify tests and dependencies #1999

Merged
merged 7 commits into from
Nov 13, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Nov 12, 2023

Add support for Python 3.12. There are a few sticking points

Also

  • reduce duplication in CI workflows
  • minor cleanup in autotest/conftest.py
  • add pip to etc/environment.yml
  • replace bmipy with xmipy in etc/environment.yml
  • add IPRN value where missing in some example input files (unblocks failing CI in other PRs)
  • add generation test marker (code-generation utilities) to pytest.ini

…312), remove generate_classes tests (implicitly CI tested by generating classes from mf6 develop), add py312 classifier to pyproject.toml, add xmipy to etc/environment.yml (replace bmipy), minor simplifications to autotest/conftest.py
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #1999 (b9feade) into develop (696a209) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1999   +/-   ##
=======================================
  Coverage     72.7%   72.7%           
=======================================
  Files          258     258           
  Lines        58824   58824           
=======================================
  Hits         42794   42794           
  Misses       16030   16030           

…s without pytest-virtualenv (fall back to virtualenv directly), remove scripts/pull_request_prepare.py (prep for ruff to replace other linting/formatting tools in subsequent PR)
@wpbonelli wpbonelli marked this pull request as ready for review November 13, 2023 19:39
@wpbonelli wpbonelli merged commit af8954b into modflowpy:develop Nov 13, 2023
24 checks passed
@wpbonelli wpbonelli deleted the py312 branch November 13, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant