-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(modpathfile): step toward generic particle tracking api #2127
Conversation
* introduce particletracking module and ParticleTrackFile base class * rename _ModpathSeries -> ModpathFile * deduplicate shared logic in ModpathFile * add dtypes as public class attributes * clarify canonical (minimal) fields * prep to support PRT output files
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2127 +/- ##
=========================================
+ Coverage 71.3% 73.1% +1.7%
=========================================
Files 259 260 +1
Lines 59511 59411 -100
=========================================
+ Hits 42479 43444 +965
+ Misses 17032 15967 -1065
|
on second thought I restored the |
Refactoring in preparation to support PRT output files under a unified interface.
ParticleTrackFile
base class_ModpathSeries
->ModpathFile
plotutil.py
The PR avoids breaking changes except one: since alledit: see comment belowParticleTrackFile
children will share the base implementation ofwrite_shapefile()
the first param becomes simplydata
. While this may break uses ofpathline_data
/etc named params, it seems like a small enough change to make in the next minor release