Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gridintersect): relax cell boundary checks with np.isclose #2173

Merged
merged 1 commit into from
May 6, 2024

Conversation

wpbonelli
Copy link
Member

@dbrakenhoff
Copy link
Contributor

Looks good to me! I think np.isclose defaults should be fine? Maybe @vincentpost has an example/test to add?

@wpbonelli wpbonelli marked this pull request as ready for review May 2, 2024 13:25
@wpbonelli
Copy link
Member Author

@vincentpost I will merge so this can at least get some exercise in mf6 CI and maybe some user testing in the next couple weeks. If you have a test case please feel free to submit separately. thanks!

@wpbonelli wpbonelli merged commit 15d1d7f into modflowpy:develop May 6, 2024
24 checks passed
@wpbonelli wpbonelli deleted the 2049 branch May 6, 2024 15:07
@vincentpost
Copy link
Contributor

Sorry for responding to this so late, and for breaking my promise to implement the fix, so thanks @wpbonelli for doing this.

I have tried to design a test problem but I could not reproduce the error because it depends on numerical round off, so it's kind of random. But I have done a test with the model in which the problem originally occurred and I can confirm that the fix solves the issue #2049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: GridIntersect's intersect method may throw IndexError when LineString starts outside model grid
3 participants