fix(styles): platform evaluation for Linux was incorrect

[jdhughes-usgs]

No description provided.

[jdhughes-usgs]

@wpbonelli I am surprised we haven't caught the issue with flopy.plot.styles on Linux before. platform.platform was being compared to "linux", which as far as I can see is always "Linux". Am I missing something?

[mwtoews]

Another "fix" would be to remove the extra path logic using two style files and just make one style file with a bunch of alternative names for "font.sans-serif". I.e., remove usgsmap_linux.mplstyle and usgsplot_linux.mplstyle and with the two remaining style files, define:

font.sans-serif: Arial, Liberation Sans

and maybe add other possible sans-serif fonts to choose. See this file for default styles.

[wpbonelli]

I'm surprised we haven't caught this too. I like your idea @mwtoews, maybe we come back to that

[jdhughes-usgs]

Another "fix" would be to remove the extra path logic using two style files and just make one style file with a bunch of alternative names for "font.sans-serif". I.e., remove usgsmap_linux.mplstyle and usgsplot_linux.mplstyle and with the two remaining style files, define:

font.sans-serif: Arial, Liberation Sans

and maybe add other possible sans-serif fonts to choose. See this file for default styles.

This is a better approach since it simplifies things. Thanks for the suggestion @mwtoews

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.6%. Comparing base (029a4e1) to head (c4388e2).
Report is 17 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #2188     +/-   ##
=========================================
+ Coverage     68.3%   70.6%   +2.2%     
=========================================
  Files          260     261      +1     
  Lines        57947   58080    +133     
=========================================
+ Hits         39611   41022   +1411     
+ Misses       18336   17058   -1278     

Files	Coverage Δ
flopy/plot/styles.py	27.2% <ø> (-0.2%)	⬇️

... and 141 files with indirect coverage changes