Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix defensive assertions for Ray Client users #2844

Closed
devin-petersohn opened this issue Mar 10, 2021 · 1 comment · Fixed by #2851
Closed

Fix defensive assertions for Ray Client users #2844

devin-petersohn opened this issue Mar 10, 2021 · 1 comment · Fixed by #2851
Labels
bug 🦗 Something isn't working P0 Highest priority tasks requiring immediate fix

Comments

@devin-petersohn
Copy link
Collaborator

Related to ray-project/ray#14042

For now, we will check for both types.
@devin-petersohn devin-petersohn added bug 🦗 Something isn't working P0 Highest priority tasks requiring immediate fix labels Mar 10, 2021
@rkooo567
Copy link
Collaborator

Note; this is in progress and will be fixed in a week or so

devin-petersohn added a commit to devin-petersohn/modin that referenced this issue Mar 11, 2021
@devin-petersohn
FIX-modin-project#2844: Check for both types of ray.ObjectRef
8aebab1 
Resolves modin-project#2844

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
@devin-petersohn devin-petersohn mentioned this issue Mar 11, 2021
Merged
6 tasks
RehanSD added a commit to devin-petersohn/modin that referenced this issue Mar 11, 2021
@RehanSD
FIX-modin-project#2844: Change ray version to 1.2.0 to fix ray.util.c…
f8342af 
…lient import.

Signed-off-by: Rehan S. Durrani <rdurrani@berkeley.edu>
RehanSD added a commit to devin-petersohn/modin that referenced this issue Mar 11, 2021
@RehanSD
FIX-modin-project#2844: Increase ray core version.
9a65733 
Signed-off-by: Rehan S. Durrani <rdurrani@berkeley.edu>
RehanSD added a commit to devin-petersohn/modin that referenced this issue Mar 11, 2021
@RehanSD
FIX-modin-project#2844: Make ray.util.client import conditional.
0472a92 
Signed-off-by: Rehan S. Durrani <rdurrani@berkeley.edu>
devin-petersohn added a commit to devin-petersohn/modin that referenced this issue Mar 11, 2021
@devin-petersohn
FIX-modin-project#2844: Lint
470880d 
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
RehanSD added a commit to devin-petersohn/modin that referenced this issue Mar 12, 2021
@RehanSD
FIX-modin-project#2844: Correct object reference type to ObjectIDType.
2e33d9c 
Signed-off-by: Rehan S. Durrani <rdurrani@berkeley.edu>
williamma12 pushed a commit that referenced this issue Mar 19, 2021
@devin-petersohn
FIX-#2844: Check for both types of ray.ObjectRef (#2851)
c23b3ce 
Resolves #2844

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>

Signed-off-by: Rehan S. Durrani <rdurrani@berkeley.edu>
@ckw017 ckw017 mentioned this issue Jun 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🦗 Something isn't working P0 Highest priority tasks requiring immediate fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX-#2844: Check for both types of ray.ObjectRef devin-petersohn/modin
2 participants
@devin-petersohn @rkooo567