Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_ATTRS_NO_LOOKUP in pandas API should include ipython canary methods #7351

Closed
devin-petersohn opened this issue Jul 30, 2024 · 0 comments · Fixed by #7352
Closed

_ATTRS_NO_LOOKUP in pandas API should include ipython canary methods #7351

devin-petersohn opened this issue Jul 30, 2024 · 0 comments · Fixed by #7352

Comments

@devin-petersohn
Copy link
Collaborator

In modin/pandas/base we are missing some ipython functions that get called on cell execution within jupyter.

We should add these to avoid expensive checks that don't have any purpose in Modin (e.g. scanning the series.index on each of these method invocations). Here is the list we should add:

    "_ipython_canary_method_should_not_exist_",
    "_ipython_display_",
    "_repr_mimebundle_",
sfc-gh-dpetersohn added a commit to devin-petersohn/modin that referenced this issue Jul 30, 2024
@sfc-gh-dpetersohn
FIX-modin-project#7351: Add ipython method calls to non-lookup list
54e3a53 
Signed-off-by: Devin Petersohn <devin.petersohn@snowflake.com>
@devin-petersohn devin-petersohn mentioned this issue Jul 30, 2024
Merged
7 tasks
YarShev pushed a commit that referenced this issue Jul 31, 2024
@devin-petersohn
FIX-#7351: Add ipython method calls to non-lookup list (#7352)
621f49e 
Signed-off-by: Devin Petersohn <devin.petersohn@snowflake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX-#7351: Add ipython method calls to non-lookup list devin-petersohn/modin
1 participant
@devin-petersohn