Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty dataframe inplace operations (e.g. __setitem__ do not change the dataframe inplace) #982

Closed
devin-petersohn opened this issue Jan 10, 2020 · 0 comments · Fixed by #983
Closed

Empty dataframe inplace operations (e.g. __setitem__ do not change the dataframe inplace) #982

devin-petersohn opened this issue Jan 10, 2020 · 0 comments · Fixed by #983
Labels
bug 🦗 Something isn't working pandas concordance 🐼 Functionality that does not match pandas
Milestone
0.7.0

Comments

@devin-petersohn
Copy link
Collaborator

Describe the problem

This was reported via email.

Empty dataframe inplace operations (e.g. __setitem__ do not change the dataframe inplace). The defaulting to pandas code clause for inplace updates needs to be updated to accommodate empty dataframes.

Source code / logs

from modin import pandas as pd 
df = pd.DataFrame()
df["a"] = [1,2,3,4,45,1]
df["b"] = [1,2,3,45,6,7]
@devin-petersohn devin-petersohn added bug 🦗 Something isn't working pandas concordance 🐼 Functionality that does not match pandas labels Jan 10, 2020
@devin-petersohn devin-petersohn added this to the 0.7.0 milestone Jan 10, 2020
devin-petersohn added a commit to devin-petersohn/modin that referenced this issue Jan 10, 2020
@devin-petersohn
Fix inplace operations without inplace keyword on emtpy dataframes
db1beaa 
* Resolves modin-project#982
* Adds clause for operations that default to pandas that do not return
  any value
  * In these cases, we build the object based on the class name of the
    object in pandas
* Add some error checking cases to the default code
* Add more test cases for the emtpy dataframe case.
@devin-petersohn devin-petersohn mentioned this issue Jan 10, 2020
Merged
3 tasks
devin-petersohn added a commit that referenced this issue Jan 10, 2020
@devin-petersohn
Fix inplace operations without inplace keyword on emtpy dataframes (#983
c36592d 
)

* Resolves #982
* Adds clause for operations that default to pandas that do not return
  any value
  * In these cases, we build the object based on the class name of the
    object in pandas
* Add some error checking cases to the default code
* Add more test cases for the emtpy dataframe case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🦗 Something isn't working pandas concordance 🐼 Functionality that does not match pandas
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Fix inplace operations without inplace keyword on emtpy dataframes devin-petersohn/modin
1 participant
@devin-petersohn