Add temporary fix for ray import pandas race condition #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: simon-mo <xmo@berkeley.edu>
Codecov Report
@@ Coverage Diff @@
## master #1174 +/- ##
==========================================
- Coverage 86.95% 86.43% -0.52%
==========================================
Files 62 62
Lines 6315 6318 +3
==========================================
- Hits 5491 5461 -30
- Misses 824 857 +33
Continue to review full report at Codecov.
|
|
@simon-mo @devin-petersohn does this appear to work around the issue? |
I tried running tests on Ray several times and didn't have any fails even with 100 pytest workers. So I think the issue is indeed fixed. TeamCity confit is probably wrong and that's the reason why CI testing failed. I restarted it with modified config. |
🤖 TeamCity test results bot 🤖Ray TestsDask TestsPython Tests |
|
looks like it's passing the ray test? is there anyway to keep re-run the teamcity build multiple time? |
Yes Ray test passed with 48 workers (TeamCity system has 48 CPU cores). I don't know a way to repeat TC tests other than to restart them manually, but as I wrote before, I ran tests on another system with 100 workers and they all passed to, so I think this race condition is really fixed with this change. |
gshimansky
reviewed
Apr 13, 2020
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
devin-petersohn
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Attempt to address issues raised in ray-project/ray#7879
flake8 modinblack --check modingit commit -sadded andpassing