-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ignore] TEST-#3085: Add testing for Ray Client #3139
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Wong <chriskw.xyz@gmail.com>
Signed-off-by: Chris Wong <chriskw.xyz@gmail.com>
Signed-off-by: Chris Wong <chriskw.xyz@gmail.com>
Signed-off-by: Chris Wong <chriskw.xyz@gmail.com>
ckw017
changed the title
TEST-#3085: Add testing for Ray Client
[IGNORE] TEST-#3085: Add testing for Ray Client
Jun 9, 2021
ckw017
changed the title
[IGNORE] TEST-#3085: Add testing for Ray Client
[Ignore] TEST-#3085: Add testing for Ray Client
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Wong chriskw.xyz@gmail.com
What do these changes do?
On code side there's a new environment variable that can be set to start a ray client connection before the test session starts.
For push/ci, currently installing a wheel slightly ahead of Ray 1.4 to fix the import deserialization race condition, which seemed to crop up extra frequently when using ray client. Since client is a bit finicky with multiple connections at the moment the
-n 2
flag with pytest doesn't work, so I separated out the tests in the matrix so that they wouldn't bottleneck the completion time (similar to what's being done for test windows). I've also left out the following tests which are failing due to reasons unrelated to ray client (primarily seems like there's been a change with how errors are propagated since 1.1 which the test suite doesn't yet handle)modin/pandas/test/dataframe/test_binary.py
modin/pandas/test/dataframe/test_map_metadata.py
modin/pandas/test/dataframe/test_reduction.py
modin/pandas/test/dataframe/test_udf.py
modin/pandas/test/test_series.py
modin/experimental/pandas/test/test_io_exp.py
flake8 modin
black --check modin
git commit -s
docs/developer/architecture.rst
is up-to-date