Refactor#3622 #3638
Closed
Refactor#3622 #3638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all modin.pandas releated tests from modin/modin/pandas/test into modin/modin/test/pandas. change conftest.py to adapt regarding. Change entries in CI - .github/workflows/*.yml to use the changed folders instead of the old ones Signed-off-by: Bertold Sedlak <berti.sedlak@gmail.com>
Fix import error within experimental pandas test using previously moved test file Signed-off-by: Bertold Sedlak <berti.sedlak@gmail.com>
Fix references in Files to import modin.pandas.test or using modin/pandas/test to new version Also fix references in documentation. Signed-off-by: Bertold Sedlak <berti.sedlak@gmail.com>
|
need to add colon (:) to commit messages, to follow guidelines.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Working on Issue #3622
Move Tests for modin.pandas into directory modin/test/pandas and changing all references either in
not resolving issue completely, as same needs to be done for other tests (I will do, after this PR is accepted, or shall I work on the whole issue before openin PR?).
Not all tests where succesfull, but the same failed in master (so in upstream without modifications).
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/developer/architecture.rstis up-to-date