DOCS-#4082: Add pdf/epub/htmlzip formats for doc builds
#4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4083 +/- ##
===========================================
- Coverage 85.61% 63.48% -22.14%
===========================================
Files 201 201
Lines 16852 16852
===========================================
- Hits 14428 10698 -3730
- Misses 2424 6154 +3730
Continue to review full report at Codecov.
|
|
|
|
RehanSD
requested changes
Jan 27, 2022
Nice catch! |
prutskov
changed the title
pdf/epub formats for doc buildspdf/epub/htmlzip formats for doc builds
…uilds Signed-off-by: Alexey Prutskov <alexey.prutskov@intel.com>
prutskov
force-pushed
the
prutskov/issue4082
branch
from
60c4a04 to
e769481
Compare
prutskov
commented
Jan 28, 2022
| @@ -23,6 +23,7 @@ Key Features and Updates | |||
| * | |||
| * Documentation improvements | |||
| * DOCS-#4077: Add release notes template to docs folder (#4078) | |||
| * DOCS-#4082: Add pdf/epub/htmlzip formats for doc builds (#4083) | |||
There was a problem hiding this comment.
@RehanSD I've added a type/issue number/PR name/ PR number as it's described in example above. But I didn't find an example where I should place my github username. Should it be placed in "Contributors" section or not? Example doesn't show where I should put it
There was a problem hiding this comment.
Yes please! For context, this is the release description you see here, so please add your name to the Contributors section with an @ so GitHub can also auto link your profile!
There was a problem hiding this comment.
Type/Issue/Pr Title + Number look perfect! I suspect Devin forgot to add his name to the contributors, which I'll fix when I add my docs fix PR that got merged last night to this template!
devin-petersohn
pushed a commit
that referenced
this pull request
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexey Prutskov alexey.prutskov@intel.com
What do these changes do?
PR adds missed after #4073 formats of doc builds
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -spdfandepubdoc builds are missed after adding.readthedocs.yaml#4082docs/development/architecture.rstis up-to-date