Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT-#4746: Sync interchange protocol with recent API changes #4763

Merged
merged 12 commits into from
Aug 13, 2022

Conversation

vnlitvinov
Copy link
Collaborator

@vnlitvinov vnlitvinov commented Aug 3, 2022

What do these changes do?

  • commit message follows format outlined here
  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Fix Modin conformance to data interchange API spec #4746
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date
  • added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
@vnlitvinov vnlitvinov force-pushed the sync-interchange-proto branch from 76e4137 to 96825b6 Compare August 3, 2022 14:10
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #4763 (880395c) into master (6e1849f) will increase coverage by 4.72%.
The diff coverage is 98.70%.

@@            Coverage Diff             @@
##           master    #4763      +/-   ##
==========================================
+ Coverage   85.28%   90.01%   +4.72%     
==========================================
  Files         259      260       +1     
  Lines       19407    19708     +301     
==========================================
+ Hits        16552    17740    +1188     
+ Misses       2855     1968     -887     
Impacted Files Coverage Δ
modin/core/dataframe/base/interchange/__init__.py 100.00% <ø> (ø)
...me/base/interchange/dataframe_protocol/__init__.py 100.00% <ø> (ø)
...frame/base/interchange/dataframe_protocol/utils.py 98.55% <ø> (ø)
...odin/core/dataframe/pandas/interchange/__init__.py 100.00% <ø> (ø)
.../pandas/interchange/dataframe_protocol/__init__.py 100.00% <ø> (ø)
...pandas/interchange/dataframe_protocol/exception.py 100.00% <ø> (ø)
modin/core/dataframe/pandas/dataframe/dataframe.py 94.22% <66.66%> (-0.12%) ⬇️
...e/base/interchange/dataframe_protocol/dataframe.py 100.00% <100.00%> (ø)
...me/pandas/interchange/dataframe_protocol/buffer.py 85.18% <100.00%> (ø)
...me/pandas/interchange/dataframe_protocol/column.py 93.33% <100.00%> (ø)
... and 51 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vnlitvinov vnlitvinov force-pushed the sync-interchange-proto branch from 96825b6 to f2433b8 Compare August 3, 2022 14:19
Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
@vnlitvinov vnlitvinov force-pushed the sync-interchange-proto branch from f2433b8 to 1f40f52 Compare August 3, 2022 15:14
@vnlitvinov
Copy link
Collaborator Author

Could @YarShev and @dchigarev help me on this please?..

Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
@vnlitvinov vnlitvinov marked this pull request as ready for review August 4, 2022 10:14
@vnlitvinov vnlitvinov requested review from a team as code owners August 4, 2022 10:14
Copy link
Collaborator

@mvashishtha mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one minor comment.

Co-authored-by: Dmitry Chigarev <zeeron209@gmail.com>
@vnlitvinov vnlitvinov force-pushed the sync-interchange-proto branch from 8a8e4ab to a9fd84a Compare August 10, 2022 08:10
@vnlitvinov vnlitvinov force-pushed the sync-interchange-proto branch 2 times, most recently from e108e93 to 70698b0 Compare August 10, 2022 11:08
@vnlitvinov
Copy link
Collaborator Author

test-ubuntu tests fail because of #4802

Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
mvashishtha
mvashishtha previously approved these changes Aug 10, 2022
Copy link
Collaborator

@mvashishtha mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vnlitvinov and others added 2 commits August 12, 2022 18:57
Co-authored-by: Yaroslav Igoshev <Poolliver868@mail.ru>
Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
@YarShev YarShev merged commit 91ac777 into modin-project:master Aug 13, 2022
@vnlitvinov vnlitvinov deleted the sync-interchange-proto branch August 15, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Modin conformance to data interchange API spec
4 participants