-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#4746: Sync interchange protocol with recent API changes #4763
FEAT-#4746: Sync interchange protocol with recent API changes #4763
Conversation
Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
76e4137
to
96825b6
Compare
Codecov Report
@@ Coverage Diff @@
## master #4763 +/- ##
==========================================
+ Coverage 85.28% 90.01% +4.72%
==========================================
Files 259 260 +1
Lines 19407 19708 +301
==========================================
+ Hits 16552 17740 +1188
+ Misses 2855 1968 -887
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
96825b6
to
f2433b8
Compare
Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
f2433b8
to
1f40f52
Compare
Could @YarShev and @dchigarev help me on this please?.. |
Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one minor comment.
modin/core/dataframe/base/interchange/dataframe_protocol/dataframe.py
Outdated
Show resolved
Hide resolved
.../execution/native/implementations/omnisci_on_native/interchange/dataframe_protocol/column.py
Outdated
Show resolved
Hide resolved
modin/core/dataframe/pandas/interchange/dataframe_protocol/column.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Dmitry Chigarev <zeeron209@gmail.com>
8a8e4ab
to
a9fd84a
Compare
Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
e108e93
to
70698b0
Compare
|
Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
70698b0
to
52ad272
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
modin/core/dataframe/pandas/interchange/dataframe_protocol/column.py
Outdated
Show resolved
Hide resolved
.../execution/native/implementations/omnisci_on_native/interchange/dataframe_protocol/column.py
Show resolved
Hide resolved
Co-authored-by: Yaroslav Igoshev <Poolliver868@mail.ru> Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date