Skip to content

Conversation

@devin-petersohn
Copy link
Collaborator

@devin-petersohn devin-petersohn commented May 24, 2023

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Use reset_index instead of insert on to_sql #6204
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
@devin-petersohn devin-petersohn requested a review from a team as a code owner May 24, 2023 18:31
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
mvashishtha
mvashishtha previously approved these changes May 24, 2023
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
@devin-petersohn devin-petersohn merged commit 98afb7f into modin-project:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use reset_index instead of insert on to_sql

2 participants