Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT-#7340: Add more granular lazy flags to query compiler #7348

Merged

Conversation

noloerino
Copy link
Collaborator

What do these changes do?

This PR adds more granular flags for lazy evaluation, as described in #7340. This also removes the existing lazy_execution flag; the new, specific flags should be used instead. From the issue:

lazy_row_labels for backends that defer computations of index
lazy_row_count to defer computation of len(index)
lazy_column_types to defer computation of dtypes
lazy_column_labels to defer computation of columns
lazy_column_count to defer computation of len(columns)

This also adds lazy_shape = lazy_row_count or lazy_column_count for convenience, as many frontend methods perform emptiness checks that may be elided.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Add more granular lazy execution flags in query compiler #7340
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Copy link
Collaborator

@devin-petersohn devin-petersohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devin-petersohn devin-petersohn merged commit a40cef7 into modin-project:main Jul 29, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more granular lazy execution flags in query compiler
3 participants