Skip to content

Commit

Permalink
fix(frontend): remove duplicate id for searchbars (#3000)
Browse files Browse the repository at this point in the history
Only one element should have the same id. The id is used to link with the label's `for` attribute. There may be similar issues other places, but this is the one that was brought to my attention.

Resolves #2999
  • Loading branch information
Erb3 authored Dec 10, 2024
1 parent d851f32 commit 7d480ff
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions apps/frontend/src/pages/search/[searchProjectType].vue
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@
<section class="card gap-1" :class="{ 'max-lg:!hidden': !sidebarMenuOpen }">
<div class="flex items-center gap-2">
<div class="iconified-input w-full">
<label class="hidden" for="search">Search</label>
<label class="hidden" for="filter-search">Search</label>
<SearchIcon aria-hidden="true" />
<input
id="search"
id="filter-search"
v-model="queryFilter"
name="search"
name="filter-search"
type="search"
placeholder="Search filters..."
autocomplete="off"
Expand Down Expand Up @@ -174,13 +174,13 @@
Filters...
</button>
<div class="iconified-input">
<label class="hidden" for="search">Search</label>
<label class="hidden" for="project-search">Search</label>
<SearchIcon aria-hidden="true" />
<input
id="search"
id="project-search"
v-model="query"
type="search"
name="search"
name="project-search"
:placeholder="`Search ${projectType.display}s...`"
autocomplete="off"
@input="onSearchChange(1)"
Expand Down

0 comments on commit 7d480ff

Please sign in to comment.