Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): General documentation improvements (OAuth documentation, docs meta) #2855

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(docs): General documentation improvements (OAuth documentation, docs meta) #2855

wants to merge 7 commits into from
+347 −263

Conversation

worldwidepixel
Copy link

@worldwidepixel worldwidepixel commented Oct 23, 2024 •
edited
Loading

Multiple beneficial additions to Docs site

  • Fixes favicon (expected SVG, got ICO) Fix removed, implemented in fix(docs): correct favicon url #2843
  • Adds properly detailed instructions for prospective Docs contributors
  • Improves documentation of Modrinth's Oauth2 capabilities

I'm worried that my code formatter may have accidentally gotten a little overzealous with openapi.yaml, so that may be an issue.

@Erb3
Copy link
Contributor

Erb3 commented Oct 23, 2024

See #2843

@worldwidepixel
Copy link
Author

worldwidepixel commented Oct 23, 2024 •
edited
Loading

I probably should have split my content additions and favicon fixes; This PR is not just to fix the issue #2843 resolves.

@worldwidepixel
Merge branch 'main' into main
8da31dc 
Signed-off-by: worldwidepixel <58098422+worldwidepixel@users.noreply.github.com>
@worldwidepixel
Merge branch 'main' into main
a43e340 
Signed-off-by: worldwidepixel <58098422+worldwidepixel@users.noreply.github.com>
@worldwidepixel
Remove favicon changes (already fixed in other PR)
c033a06 
Signed-off-by: worldwidepixel <58098422+worldwidepixel@users.noreply.github.com>
@worldwidepixel worldwidepixel changed the title feat: All good Docs things under the sun (favicon, oauth2, docs meta) feat: All good Docs things under the sun (OAuth documentation, docs meta) Nov 11, 2024
@worldwidepixel worldwidepixel changed the title feat: All good Docs things under the sun (OAuth documentation, docs meta) feat(docs): All good Docs things under the sun (OAuth documentation, docs meta) Nov 11, 2024
@worldwidepixel
Copy link
Author

Removed favicon change (#2843); Resolved conflicts

@worldwidepixel worldwidepixel changed the title feat(docs): All good Docs things under the sun (OAuth documentation, docs meta) feat(docs): General documentation improvements (OAuth documentation, docs meta) Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worldwidepixel @Erb3