Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move docker compose to example #2888

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Erb3
Copy link
Contributor

@Erb3 Erb3 commented Nov 3, 2024

I have renamed docker-compose.yml into docker-compose.example.yml because this makes it easier to develop. I as a developer might already have postgres running locally, and not need the additional instance. I then edit the compose to fix this, but git will get angry at me. This change will let you edit the compose to fit your needs. The only downside is having to copy the file.

  • Rename docker-compose.yml to docker-compose.example.yml
  • Remove version: '3' from compose as it has been deprecated and creates warnings
  • Update CI to respect this change
  • Add docker-compose.yml to .gitignore
  • Remove duplicate entry for .env in .gitignore
  • Run formatter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant