Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use en dash for versions range instead of em dash #2997

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Use en dash for versions range instead of em dash #2997

merged 3 commits into from
Dec 15, 2024

Conversation

zefir-git
Copy link
Contributor

An en dash is the appropriate punctuation for ranges (numbers, dates, versions).

❌ incorrect ✅ correct
1.20—1.21.4 1.20–1.21.4
em dash en dash

Similar: modrinth/knossos#1246

Erb3
Erb3 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@Erb3 Erb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete match against modrinth/labrinth#816. LGTM

@Geometrically Geometrically added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@Prospector Prospector added this pull request to the merge queue Dec 15, 2024
Merged via the queue into modrinth:main with commit 58cbc1a Dec 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geometrically Geometrically Geometrically approved these changes

@Erb3 Erb3 Erb3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zefir-git @Geometrically @Erb3 @Prospector