Skip to content

feat(app): skins frontend #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 83 commits into
base: main
Choose a base branch
from
Open

feat(app): skins frontend #3657

wants to merge 83 commits into from

Conversation

IMB11
Copy link
Member

@IMB11 IMB11 commented May 15, 2025 •
edited
Loading

Closes: #415

@AlexTMjugador AlexTMjugador changed the base branch from skins-frontend to main May 16, 2025 10:57
@AlexTMjugador AlexTMjugador changed the base branch from main to skins-frontend May 16, 2025 10:58
@AlexTMjugador
Copy link
Member

Prior work at #3491, #3525 and skins-frontend branch. There is a PR train going on here, so we should either merge the dependent branches in that order, or change the base of this branch to main. Further work on this feature should ideally be pushed to this branch.

@AlexTMjugador AlexTMjugador added enhancement New feature or request app Relates to Modrinth App labels May 16, 2025
@IMB11 IMB11 mentioned this pull request Jun 3, 2025
Closed
@IMB11 IMB11 changed the title Finish skins frontend feat: skins frontend Jun 13, 2025
This was referenced Jun 13, 2025
Draft
Draft
AlexTMjugador and others added 13 commits June 14, 2025 16:14
@AlexTMjugador
chore: typo fix and formatting tidyups
f210de5
@AlexTMjugador
refactor(theseus): extend auth subsystem to fetch complete user profiles
ed8ff79
@AlexTMjugador
chore: fix new prettier lints
8abbc02
@AlexTMjugador
chore: document differences between similar Credentials methods
23f0c1d
@AlexTMjugador
chore: remove dead profile_run_credentials plugin command
f07bc86
@AlexTMjugador
feat(app): skin selector backend
e189219
@AlexTMjugador
enh(app/skin-selector): better DB intension through deferred FKs, fur…
a822613 
…ther PNG validations
@AlexTMjugador
chore: fix comment typo spotted by Copilot
8ecc7c5
@AlexTMjugador
fix: less racy auth token refresh logic
65d15fe 
This may help with issues reported by users where the access token is
invalid and can't be used to join servers over long periods of time.
@AlexTMjugador
tweak(app-lib): improve consistency of skin field serialization case
9dda6e0
@AlexTMjugador
fix(app-lib/minecraft_skins): fix custom skin removal from DB not wor…
3587b0a 
…king
@Prospector @AlexTMjugador
Begin skins frontend
161dc73
@Prospector @AlexTMjugador
Cape preview
5a8bbae
AlexTMjugador and others added 15 commits June 14, 2025 17:47
@AlexTMjugador
feat(app/minecraft_skins): save current custom external skin when equ…
0155262 
…ipping skins
@IMB11 @AlexTMjugador
fix: cape button & dynamic nametag sizing
3b9cbc6
@AlexTMjugador
feat(theseus): add normalize_skin_texture Tauri command
33269d3 
This command lets the app frontend opt in to normalizing the texture of
any skin, which may be in either the legacy 64x32 or newer 64x64 format,
to the newer 64x64 format for display purposes.
@AlexTMjugador
chore: Rust build fixes
5fa9a0e
@IMB11 @AlexTMjugador
feat: start impl of skin normalization on frontend
774950d
@AlexTMjugador
feat(theseus): change parameter type of normalize_skin_texture Taur…
92f281a 
…i command
@IMB11 @AlexTMjugador
fix: normalization
6c5480e
@AlexTMjugador
fix(theseus): make new normalize_skin_texture command usable
4f70e79
@IMB11 @AlexTMjugador
feat: finish normalization impl
a22d90a
@IMB11 @AlexTMjugador
fix: vueuse issue
34e49d4
@IMB11 @AlexTMjugador
fix: use optimistic approach when changing skins/capes.
006611b
@IMB11 @AlexTMjugador
fix: nametag cleanup + scroll fix
d37e8fd
@IMB11 @AlexTMjugador
fix: edit modal computedAsync not fast enough for skin preview renderer
97042fb
@IMB11 @AlexTMjugador
feat: classic player model animations
3133cec
@AlexTMjugador
chore: fix new Clippy lint
4ba5498
@IMB11 IMB11 changed the title feat: skins frontend feat(app): skins frontend Jun 14, 2025
@AlexTMjugador AlexTMjugador changed the base branch from skins-frontend to main June 14, 2025 16:23
@IMB11 IMB11 marked this pull request as ready for review June 15, 2025 23:51
@IMB11 IMB11 requested a review from Prospector June 15, 2025 23:51
@IMB11
Copy link
Member Author

IMB11 commented Jun 15, 2025

Pending minor animation+model tweaks and then we should be good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTMjugador AlexTMjugador AlexTMjugador approved these changes

@Prospector Prospector Awaiting requested review from Prospector

Assignees
No one assigned
Labels
app Relates to Modrinth App enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skins page
3 participants
@IMB11 @AlexTMjugador @Prospector