Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow passing multiple arguments to dependency DSL calls #61

Merged
merged 4 commits into from
Dec 3, 2023
Merged

allow passing multiple arguments to dependency DSL calls #61

merged 4 commits into from
Dec 3, 2023

Conversation

JT122406
Copy link
Contributor

@JT122406 JT122406 commented Dec 3, 2023

No description provided.

triphora
triphora reviewed Dec 3, 2023
View reviewed changes
Copy link
Contributor

@triphora triphora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this doesn't break API, but would it break ABI since the signature of the methods changed?

@JT122406
Copy link
Contributor Author

JT122406 commented Dec 3, 2023

I know this doesn't break API, but would it break ABI since the signature of the methods changed?

It shouldn't

triphora
triphora approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@triphora triphora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well, just some code formatting stuff

src/main/java/com/modrinth/minotaur/dependencies/container/NamedDependencyContainer.java Outdated Show resolved Hide resolved
src/main/java/com/modrinth/minotaur/dependencies/container/NamedDependencyContainer.java Outdated Show resolved Hide resolved
@triphora triphora changed the title allow passing multiple arguments in project and version methods in NamedDependencyContainer allow passing multiple arguments to dependency DSL calls Dec 3, 2023
@triphora triphora merged commit db76ec2 into modrinth:master Dec 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triphora triphora triphora approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JT122406 @triphora