Enhance GPT example user experience #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying out Modula and, with this PR, I’ve implemented a more straightforward way to work with the GPT example. The changes include adding inference code, a command line interface, and support for using different datasets.
There’s still a fair amount of repetitive code and assumptions connecting
examples/data/shakespeare.pyandexamples/gpt.py. If you’re open to it, I’d be glad to implement aprepare-datasub-command in the CLI. This would make it much easier to prepare and train on alternative datasets, which I think could be highly useful when exploring different possibilities with the tool.