This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Description / doc changes related to spanner instances in Terraform. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def async_op_url(module, extra_data=None): | ||
| if extra_data is None: | ||
| extra_data = {} | ||
| url = "https://spanner.googleapis.com/v1/projects/{project}/global/operations/{op_id}" |
There was a problem hiding this comment.
This is wrong, of course - but it's not obviously more wrong than the existing behavior, which doesn't wait at all. What should I do?
There was a problem hiding this comment.
Merge it in and file a bug.
rambleraptor
approved these changes
Jan 17, 2019
modular-magician
force-pushed
the
codegen-pr-1266
branch
2 times, most recently
from
e81d6d8 to
61430b8
Compare
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
force-pushed
the
codegen-pr-1266
branch
from
61430b8 to
c851998
Compare
rambleraptor
pushed a commit
that referenced
this pull request
May 21, 2019
…171) Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
added a commit
that referenced
this pull request
Sep 5, 2019
…171) Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @ndmckinley