Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] use self.cap in heap allocated array example #4126

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

illiasheshyn
Copy link

@illiasheshyn illiasheshyn commented Mar 9, 2025

Just some minor neat-picks spotted as I was reading through Life of a value page. The corresponding issue #4127

Changes

  • 3 cases of implicit conversion are now mentioned, replaces both with all
  • uses self.cap to allocate memory (consistent with the previous HeapArray example on the same page)

Signed-off-by: Illia Sheshyn <187636533+illiasheshyn@users.noreply.github.com>
Signed-off-by: Illia Sheshyn <187636533+illiasheshyn@users.noreply.github.com>
Signed-off-by: Illia Sheshyn <187636533+illiasheshyn@users.noreply.github.com>
@illiasheshyn
Copy link
Author

feels wrong to lump unrelated changes under this issue, I'm happy to raise the last commit in a separate issue if needed.

Copy link
Collaborator

@JoeLoser JoeLoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc edits! No worries about lumping in the minor change in mojo/docs/manual/functions.mdx in this case 👍

@JoeLoser
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported-internally Signals that a given pull request has been imported internally.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants