fix relative imports and --target setting #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
ZolotukhinM
approved these changes
Aug 8, 2024
Collaborator
ZolotukhinM
left a comment
ZolotukhinM
left a comment
There was a problem hiding this comment.
Fix for the first part looks good to me, thanks for catching that! I'll defer to @zbowling for the second part of the PR as I'm less familiar with how packaging works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1:
--target bug, "/main" was hardcoded
Issue 2:
Relative imports are hard to work with. E.g.
~/stack_pr
~/my_repo
In my repo, I can not python -m call into ~/stack_pr, because I can not go up in the directory hierarhy, I think.
So my approach is:
then within ~/my_repo I can do