Fix delete_remote_branches #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete_remote_branches formatted remote branch refs with an extra single quote around each branch. These would never match the branch strings stored in stack entries, so remote branches would never get deleted. This commit removes the extra single quotes.
Contributor
Author
|
I submitted two PRs fixing issues I found with the tool while using it for the first time today. Happy to modify anything according to contributing guidelines. Other than testing using the tool on my own project, I did not test it in any other way. |
Closed
Collaborator
|
Thank you for the fixes, I merged this one and left some comments on the other one! |
ZolotukhinM
added a commit
that referenced
this pull request
Oct 12, 2024
GitHub deletes the remote branch automatically when the PR is merged, so we don't to explicitly do that. Trying to delete it currently results in an error like this: ``` error: unable to delete 'ZolotukhinM/stack/1': remote ref does not exist error: failed to push some refs to '...' ``` The code for deleting the branch has been sitting there for a long time, but until a fix in #27 it used incorrect branch names.
ZolotukhinM
added a commit
that referenced
this pull request
Oct 12, 2024
GitHub deletes the remote branch automatically when the PR is merged, so we don't to explicitly do that. Trying to delete it currently results in an error like this: ``` error: unable to delete 'ZolotukhinM/stack/1': remote ref does not exist error: failed to push some refs to '...' ``` The code for deleting the branch has been sitting there for a long time, but until a fix in #27 it used incorrect branch names. stack-info: PR: #42, branch: ZolotukhinM/stack/1
ZolotukhinM
added a commit
that referenced
this pull request
Oct 12, 2024
GitHub deletes the remote branch automatically when the PR is merged, so we don't to explicitly do that. Trying to delete it currently results in an error like this: ``` error: unable to delete 'ZolotukhinM/stack/1': remote ref does not exist error: failed to push some refs to '...' ``` The code for deleting the branch has been sitting there for a long time, but until a fix in #27 it used incorrect branch names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete_remote_branches formatted remote
branch refs with an extra single quote
around each branch. These would never
match the branch strings stored in
stack entries, so remote branches would
never get deleted. This commit removes
the extra single quotes.