This PR adds the missing bash to the magic run bash run.sh which

without it seems to cause errors for some users. Also makes `console.py` to use magic. MODULAR_ORIG_COMMIT_REV_ID: ebadc222826cef6bd4dd1664709a9f9f7dfe212c
modularml · Dec 17, 2024 · b44221f · b44221f
1 parent bf214df
commit b44221f
Show file tree

Hide file tree

Showing 9 changed files with 10 additions and 15 deletions.
diff --git a/examples/console.py b/examples/console.py
@@ -142,13 +142,8 @@ def select_repository(
 
 def run_repository(repo_name: str) -> None:
     repo_path = os.path.join(ROOT, repo_name)
-    requirements_path = os.path.join(repo_path, "requirements.txt")
     run_script_path = (Path(repo_path) / "run.sh").resolve()
-
-    if os.path.exists(requirements_path):
-        subprocess.run(["pip", "install", "-r", requirements_path])
-
-    subprocess.run(["bash", run_script_path], cwd=repo_path)
+    subprocess.run(["magic", "run", "bash", run_script_path], cwd=repo_path)
     return
 
 

diff --git a/examples/inference/bert-c-torchscript/README.md b/examples/inference/bert-c-torchscript/README.md
@@ -13,7 +13,7 @@ If you have [`magic`](https://docs.modular.com/magic), you can run the
 following command:
 
 ```sh
-magic run run.sh
+magic run bash run.sh
 ```
 
 ### Conda instructions

diff --git a/examples/inference/bert-mojo-torchscript/README.md b/examples/inference/bert-mojo-torchscript/README.md
@@ -12,7 +12,7 @@ If you have [`magic`](https://docs.modular.com/magic), you can run the
 following command:
 
 ```sh
-magic run run.sh
+magic run bash run.sh
 ```
 
 ### Conda instructions

diff --git a/examples/inference/bert-python-torchscript/README.md b/examples/inference/bert-python-torchscript/README.md
@@ -12,9 +12,9 @@ following command:
 
 ```sh
 # Run the MAX Engine example
-magic run run.sh
+magic run bash run.sh
 # Run the MAX Serving example
-magic run deploy.sh
+magic run bash deploy.sh
 ```
 
 ### Conda instructions

diff --git a/examples/inference/mistral7b-python-onnx/README.md b/examples/inference/mistral7b-python-onnx/README.md
@@ -24,7 +24,7 @@ following command:
 
 ```sh
 # Run the MAX Engine example
-HF_TOKEN=<your-huggingface-user-token> magic run run.sh
+HF_TOKEN=<your-huggingface-user-token> magic run bash run.sh
 ```
 
 ### Conda instructions

diff --git a/examples/inference/resnet50-python-torchscript/README.md b/examples/inference/resnet50-python-torchscript/README.md
@@ -12,7 +12,7 @@ If you have [`magic`](https://docs.modular.com/magic), you can run the
 following command:
 
 ```sh
-magic run run.sh
+magic run bash run.sh
 ```
 
 ### Conda instructions

diff --git a/examples/inference/stable-diffusion-mojo-onnx/README.md b/examples/inference/stable-diffusion-mojo-onnx/README.md
@@ -12,7 +12,7 @@ If you have [`magic`](https://docs.modular.com/magic), you can run the
 following command:
 
 ```sh
-magic run run.sh
+magic run bash run.sh
 ```
 
 ### Conda instructions

diff --git a/examples/inference/stable-diffusion-python-onnx/README.md b/examples/inference/stable-diffusion-python-onnx/README.md
@@ -12,7 +12,7 @@ If you have [`magic`](https://docs.modular.com/magic), you can run the
 following command:
 
 ```sh
-magic run run.sh
+magic run bash run.sh
 ```
 
 ### Conda instructions

diff --git a/examples/inference/yolo-python-onnx/README.md b/examples/inference/yolo-python-onnx/README.md
@@ -20,7 +20,7 @@ If you have [`magic`](https://docs.modular.com/magic), you can run the
 following command:
 
 ```sh
-magic run run.sh
+magic run bash run.sh
 ```
 
 ### Conda instructions