Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[manual] Add missing traits in manual #2887

Merged
merged 3 commits into from
Jun 3, 2024
Merged

[manual] Add missing traits in manual #2887

merged 3 commits into from
Jun 3, 2024

Conversation

msaelices
Copy link
Contributor

  • Absable
  • Boolean{Key,Collection}Element
  • Comparable
  • ComparableCollectionElement
  • Defaultable
  • Formattable
  • Hashable
  • Indexer
  • Powable
  • Representable
  • Representable{Key,Collection}Element
  • Roundable
  • StringableCollectionElement
  • ToFormatter
  • Truncable

@msaelices
[doc] Add missing built-in traits to the manual
474a130 
Absable, Roundable, Boolean{Key,Collection}Element, Comparable,
ComparableCollectionElement, Defaultable, Formattable, Hashable,
Indexer, Powable, Representable,
Representable{Key,Collection}Element, StringableCollectionElement,
ToFormatter, Truncable

Signed-off-by: Manuel Saelices <msaelices@gmail.com>
@msaelices msaelices requested a review from a team as a code owner May 30, 2024 05:53
@laszlokindrat
Copy link
Contributor

There is a related discussion going on here: #2924 Some of these traits might be moved/renamed as a result of that.

scottamain
scottamain approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@scottamain scottamain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@scottamain
Copy link
Collaborator

There is a related discussion going on here: #2924 Some of these traits might be moved/renamed as a result of that.

Yeah, maintaining this list is not ideal, but I think this change is still a good thing. The perfect thing will be for us to generate a list of "all traits" in the stdlib somewhere and then point to that.

@scottamain scottamain merged commit 388cbdb into modularml:nightly Jun 3, 2024
4 of 5 checks passed
@arthurevans
Copy link
Collaborator

This didn't get imported via copybara, and I'm not sure what's going to happen with it.

@JoeLoser
Copy link
Collaborator

JoeLoser commented Jun 4, 2024

Since this was not imported via copybara, the next nightly release (since internal is SoT), would just blow this change away. This change now shows up with every imported PR today due to this mistake. I will fix it.

@JoeLoser
Copy link
Collaborator

JoeLoser commented Jun 4, 2024

!sync

@JoeLoser
Copy link
Collaborator

JoeLoser commented Jun 4, 2024

@arthurevans @scottamain this got incorporated into https://github.com/modularml/modular/commit/7ca8fce3da1218c13672c9c242a0fc0e89709a77#diff-4c711e538c55c32687c77ca6e97d93b46929c5526a32ad263abad90fdb2deed5 last night.

@arthurevans
Copy link
Collaborator

Thank you @JoeLoser!

@JoeLoser
Copy link
Collaborator

JoeLoser commented Jun 5, 2024

There is a related discussion going on here: #2924 Some of these traits might be moved/renamed as a result of that.

Yeah, maintaining this list is not ideal, but I think this change is still a good thing. The perfect thing will be for us to generate a list of "all traits" in the stdlib somewhere and then point to that.

Can you file an issue for Mojo tooling team? This shouldn't be that difficult for the doc gen tooling today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottamain scottamain scottamain approved these changes

Assignees

@JoeLoser JoeLoser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msaelices @laszlokindrat @scottamain @arthurevans @JoeLoser