[stdlib] Clean up memory.unsafe
#3588
Conversation
soraros
force-pushed
the
cleanup-bitcast
branch
2 times, most recently
from
0cbc317
to
130184e
Compare
soraros
force-pushed
the
cleanup-bitcast
branch
5 times, most recently
from
7509649
to
282ea3c
Compare
|
!sync |
soraros
force-pushed
the
cleanup-bitcast
branch
from
282ea3c
to
973bbe7
Compare
|
!sync |
modularbot
added
the
imported-internally
soraros
force-pushed
the
cleanup-bitcast
branch
3 times, most recently
from
3dfc9db
to
e2aebab
Compare
|
!sync |
- Make more things infer-only - Remove unnecessary overload - Rename `bitcast` overload that performs "movemask" to `pack_bits` Signed-off-by: Yiwu Chen <210at85@gmail.com>
soraros
force-pushed
the
cleanup-bitcast
branch
from
e2aebab
to
993ea69
Compare
|
!sync |
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
|
@JoeLoser Do we need to add changelog entries for this and perhaps the |
Wouldn't hurt, I agree. Want to write something up? If not, I can next week. |
|
@JoeLoser I guess it's the best if you could do is since both PRs are now merged. Thanks in advance! |
[External] [stdlib] Clean up `memory.unsafe` - Make more things infer-only - Remove unnecessary overload - Rename the `bitcast` overload that performs the 'movemask' operation to `pack_mask`. This change is intended to prevent issues where the wrong overload might be selected, and since there is an implicit conversion from scalar to simd at return, the user won't get a type mismatch error to warn them about that. Co-authored-by: soraros <soraros@users.noreply.github.com> Closes #3588 MODULAR_ORIG_COMMIT_REV_ID: 18e72968cbdadf593e6bc9bba0794e326bada362
|
Landed in bb4a60c! Thank you for your contribution 🎉 |
bitcastoverload that performs the 'movemask' operation topack_mask. This change is intended to prevent issues where the wrong overload might be selected, and since there is an implicit conversion from scalar to simd at return, the user won't get a type mismatch error to warn them about that. @JoeLoser, do you think this change is a good idea? The function in NumPy is calledpackbits, maybe that's a better name.