[stdlib] Add String __add__ with StringSlice and StringLiteral & optimize to not use List.resize()
#3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeLoser
reviewed
Oct 2, 2024
martinvuyk
added a commit
to martinvuyk/mojo
that referenced
this pull request
Oct 3, 2024
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
martinvuyk
changed the title
String __add__ with StringSlice and optimize to not use List.resize()String __add__ with StringSlice and StringLiteral & optimize to not use List.resize()
martinvuyk
force-pushed
the
add-string-stringslice-add
branch
from
d11e21d
to
f5533c7
Compare
martinvuyk
force-pushed
the
add-string-stringslice-add
branch
from
f5533c7
to
19ed88a
Compare
…t.resize Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
martinvuyk
force-pushed
the
add-string-stringslice-add
branch
from
19ed88a
to
36a4995
Compare
JoeLoser
approved these changes
Oct 14, 2024
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
|
@JoeLoser fixed :) |
|
!sync |
modularbot
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
|
Landed in 8cbfb43! Thank you for your contribution 🎉 |
modularbot
added a commit
that referenced
this pull request
Oct 16, 2024
…ringLiteral` & optimize to not use `List.resize()` (#49071) [External] [stdlib] Add `String` `__add__` with `StringSlice` and `StringLiteral` & optimize to not use `List.resize()` Add `String` `__add__` with `StringSlice` and `StringLiteral` & optimize to not use `List.resize()` ORIGINAL_AUTHOR=martinvuyk <110240700+martinvuyk@users.noreply.github.com> PUBLIC_PR_LINK=#3591 Co-authored-by: martinvuyk <110240700+martinvuyk@users.noreply.github.com> Closes #3591 MODULAR_ORIG_COMMIT_REV_ID: a01834b1eb829ffaa3e5bda5bd3fee05b3513774
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
String__add__withStringSliceandStringLiteral& optimize to not useList.resize()