Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Add examples for env_get_int and sizeof #3593

Closed
wants to merge 2 commits into from
Closed

[stdlib] Add examples for env_get_int and sizeof #3593

wants to merge 2 commits into from

Conversation

rd4com
Copy link
Contributor

@rd4com rd4com commented Oct 3, 2024

Hello, this commit adds a few examples:

  • env_get_int for parametrizing
  • sizeof for sizes

@rd4com rd4com requested a review from a team as a code owner October 3, 2024 06:09
@rd4com rd4com force-pushed the add_examples_sizeof_and_env_get_int branch from 634931b to 13ad643 Compare October 3, 2024 07:11
@rd4com
[stdlib] Add examples for env_get_int and sizeof
f804d30 
Signed-off-by: rd4com <144297616+rd4com@users.noreply.github.com>
@rd4com rd4com force-pushed the add_examples_sizeof_and_env_get_int branch from 13ad643 to f804d30 Compare October 3, 2024 07:18
@rd4com
Copy link
Contributor Author

rd4com commented Oct 3, 2024

❌ Run pre-commit / lint (pull_request):

Have to finish with `.`

✅ Had to add a note after one example:

Note: `align_of` is in same module.

@JoeLoser
Copy link
Collaborator

JoeLoser commented Oct 3, 2024 •
edited
Loading

❌ Run pre-commit / lint (pull_request):

Have to finish with `.`

✅ Had to add a note after one example:

Note: `align_of` is in same module.

Do you mind filing a GH issue for this? I think we should loosen our parsing doc requirements to allow for things of the form

some example code here

without ending in a . at the end after the code snippet when surrounded in a mojo code block denoted by three backticks.

@rd4com rd4com mentioned this pull request Oct 4, 2024
Closed
1 task
@JoeLoser
Update stdlib/src/sys/param_env.mojo
85f549e 
Signed-off-by: Joe Loser <joeloser@fastmail.com>
@JoeLoser
Copy link
Collaborator

JoeLoser commented Oct 7, 2024

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Oct 7, 2024
@modularbot
Copy link
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added the merged-internally Indicates that this pull request has been merged internally label Oct 9, 2024
modularbot pushed a commit that referenced this pull request Oct 10, 2024
@rd4com @modularbot
[External] [stdlib] Add examples for env_get_int and sizeof (#48622)
ee75c6b 
[External] [stdlib] Add examples for `env_get_int` and `sizeof`

Add a few examples:
- `env_get_int` for parametrizing
- `sizeof` for sizes

Co-authored-by: rd4com <144297616+rd4com@users.noreply.github.com>
Closes #3593
MODULAR_ORIG_COMMIT_REV_ID: 3f8ef10024ff3736cbd4f1ad56038b595ca09aea
@modularbot modularbot added the merged-externally Merged externally in public mojo repo label Oct 10, 2024
@modularbot
Copy link
Collaborator

Landed in ee75c6b! Thank you for your contribution 🎉

@modularbot modularbot closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeLoser JoeLoser JoeLoser approved these changes

Assignees

@JoeLoser JoeLoser

Labels
imported-internally Signals that a given pull request has been imported internally. merged-externally Merged externally in public mojo repo merged-internally Indicates that this pull request has been merged internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rd4com @JoeLoser @modularbot