Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Rename IntLiteral.value to IntLiteral._value. #3690

Open
wants to merge 1 commit into
base: nightly
Choose a base branch
from
Open

[stdlib] Rename IntLiteral.value to IntLiteral._value. #3690

wants to merge 1 commit into from

Conversation

helehex
Copy link
Contributor

@helehex helehex commented Oct 18, 2024

This was suggested here by Lattner.

@helehex
Rename IntLiteral.value to IntLiteral._value.
b3a40f1 
Signed-off-by: Max Brylski <helehex@gmail.com>
@helehex helehex requested a review from a team as a code owner October 18, 2024 04:37
@helehex
Copy link
Contributor Author

helehex commented Oct 18, 2024

Do we still want to do this?

@JoeLoser
Copy link
Collaborator

!sync

@JoeLoser
Copy link
Collaborator

Do we still want to do this?

IMO, yes. Thank you!

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeLoser JoeLoser JoeLoser approved these changes

Assignees

@JoeLoser JoeLoser

Labels
imported-internally Signals that a given pull request has been imported internally.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helehex @JoeLoser @modularbot