Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize modular scale #172

Open
wants to merge 64 commits into
base: 3.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
601498b
Cleanup
scottkellum May 27, 2021
d300d9a
Starting the re-write
scottkellum May 27, 2021
04e3493
Chipping away
scottkellum May 27, 2021
e135d42
Updates
scottkellum May 27, 2021
19b633d
Working on multi stranded scales
scottkellum May 27, 2021
b4228ef
Gitting the core function working
scottkellum May 27, 2021
693dd62
More iteration
scottkellum May 28, 2021
3c26ec5
Target feature done
scottkellum May 28, 2021
fa83622
Working on various responsive solutions
scottkellum May 28, 2021
7428664
Run task for Nova and respond tweak
scottkellum Jun 23, 2021
49729b5
Update Sass version number
scottkellum Jun 25, 2021
d4de970
Prototype responsive logic
scottkellum Jun 25, 2021
47716c5
Basic responsive logic in place
scottkellum Jun 25, 2021
7b9e30f
Finished responsive logic
scottkellum Jun 25, 2021
ee3f8e0
Naming tweaks
scottkellum Jun 25, 2021
b54ab0c
Tweaks and testing
scottkellum Jun 25, 2021
e1532fc
Missed a bunch of division errors. Fixed now
scottkellum Jun 25, 2021
0b5454f
Readme updates
scottkellum Jun 25, 2021
6234627
Version up
scottkellum Jun 25, 2021
0d8eb9f
Update configuration and loading
scottkellum Jul 2, 2021
1308de0
Update version
scottkellum Jul 2, 2021
5c2f68a
Document forwarding of settings functionality
scottkellum Jul 2, 2021
b65b47a
Update `gitignore`
robsonsobral Aug 1, 2021
6713c47
Install True Sass tester
robsonsobral Aug 1, 2021
b844c3f
Add test scripts
robsonsobral Aug 1, 2021
38e3140
Start to add tests
robsonsobral Aug 1, 2021
185a767
Remove wrong parameter on test scripts
robsonsobral Aug 1, 2021
4374a02
Prefix True
robsonsobral Aug 2, 2021
a9f0b5c
Rename `unitless()` to `strip-unit()` to...
robsonsobral Aug 6, 2021
26bb2bf
Test `strip-unit()`
robsonsobral Aug 6, 2021
a8f651c
Normalize IDE configurations
robsonsobral Aug 6, 2021
3e0d707
Improve `sort()` tests
robsonsobral Aug 6, 2021
0444e2e
Improve `strip-unit()` test
robsonsobral Aug 6, 2021
4ac7332
Test `to-num()` function
robsonsobral Aug 6, 2021
d9f6bba
Reorganize tests to make proper use of `--watch`...
robsonsobral Aug 6, 2021
d518da8
Test `target()` function
robsonsobral Aug 6, 2021
552f33b
Add report to tests
robsonsobral Aug 6, 2021
74145cd
Fix `/test-results` path
robsonsobral Aug 6, 2021
263b30d
Add tests to `step()` function
robsonsobral Aug 6, 2021
79c209b
Allow the use of target as "step"
robsonsobral Aug 9, 2021
d37b9fd
Accept incompatible units on `step(12px)` using 16px as root size
robsonsobral Aug 17, 2021
1fa6c0e
Remove use of `@import`
robsonsobral Aug 20, 2021
d7a4559
Improve reversed steps tests
robsonsobral Aug 20, 2021
a797012
Test settings normalizer
robsonsobral Aug 23, 2021
e40cfd7
Improve test script
robsonsobral Aug 23, 2021
c04b832
Add multiple scales to `step()` test
robsonsobral Aug 23, 2021
169be4a
Lint the code
robsonsobral Sep 30, 2021
aa4e543
Rename "vars" as "constants"
robsonsobral Oct 2, 2021
bfd03e9
Kill a gremlin
robsonsobral Oct 2, 2021
9ac3d33
Remove redundant code...
robsonsobral Oct 2, 2021
d6a41ec
Fix multi bases `step()`
robsonsobral Oct 2, 2021
379de7b
Normalize quotation marks
robsonsobral Oct 2, 2021
78d7b05
Call ratios by name...
robsonsobral Oct 3, 2021
beaec89
Allow target to be provided as list, using spaces
robsonsobral Oct 3, 2021
01376ed
Prefix `type-of()`
robsonsobral Oct 3, 2021
c7a9e2b
Rename `target()` to make its purpose clearer
robsonsobral Oct 3, 2021
77a18bd
Move `step-by-target()` to its own file
robsonsobral Oct 3, 2021
0df0c33
Rename `settings()` to `normalize-settings()`
robsonsobral Oct 3, 2021
b7616a4
Allow adding custom named ratios...
robsonsobral Oct 3, 2021
6253f52
Fix settings inheritance
robsonsobral Oct 3, 2021
a8a5c55
Combine API into one file to make easier to handle settings
robsonsobral Oct 4, 2021
e1eb838
Fix settings overriding
robsonsobral Oct 4, 2021
d6e588c
Testing responsive mixins
robsonsobral Oct 4, 2021
e40dfa2
Merge pull request #174 from robsonsobral/4.x
scottkellum Oct 7, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
Binary file not shown.
11 changes: 11 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# EditorConfig is awesome: https://EditorConfig.org

root = true

[*]
charset = utf-8
end_of_line = lf
indent_size = 2
indent_style = space
insert_final_newline = true
trim_trailing_whitespace = true
222 changes: 215 additions & 7 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,11 +1,219 @@
*.gem
.sass-cache
.bundle
libsass/node_modules
libsass/npm-debug.log

*.lock
# Created by https://www.toptal.com/developers/gitignore/api/windows,linux,macos,node,sass,visualstudiocode
# Edit at https://www.toptal.com/developers/gitignore?templates=windows,linux,macos,node,sass,visualstudiocode

stylesheets/modular-scale.zip
### Linux ###
*~

# temporary files which can be created if a process still has a handle open of a deleted file
.fuse_hidden*

# KDE directory preferences
.directory

# Linux trash folder which might appear on any partition or disk
.Trash-*

# .nfs files are created when an open file is removed but is still being accessed
.nfs*

### macOS ###
# General
.DS_Store
.AppleDouble
.LSOverride

# Icon must end with two \r
Icon


# Thumbnails
._*

# Files that might appear in the root of a volume
.DocumentRevisions-V100
.fseventsd
.Spotlight-V100
.TemporaryItems
.Trashes
.VolumeIcon.icns
.com.apple.timemachine.donotpresent

# Directories potentially created on remote AFP share
.AppleDB
.AppleDesktop
Network Trash Folder
Temporary Items
.apdisk

### Node ###
# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*
lerna-debug.log*
.pnpm-debug.log*

# Diagnostic reports (https://nodejs.org/api/report.html)
report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage
*.lcov

# nyc test coverage
.nyc_output

# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# Bower dependency directory (https://bower.io/)
bower_components

# node-waf configuration
.lock-wscript

# Compiled binary addons (https://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules/
jspm_packages/

# Snowpack dependency directory (https://snowpack.dev/)
web_modules/

# TypeScript cache
*.tsbuildinfo

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Microbundle cache
.rpt2_cache/
.rts2_cache_cjs/
.rts2_cache_es/
.rts2_cache_umd/

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity

# dotenv environment variables file
.env
.env.test
.env.production

# parcel-bundler cache (https://parceljs.org/)
.cache
.parcel-cache

# Next.js build output
.next
out

# Nuxt.js build / generate output
.nuxt
dist

# Gatsby files
.cache/
# Comment in the public line in if your project uses Gatsby and not Next.js
# https://nextjs.org/blog/next-9-1#public-directory-support
# public

# vuepress build output
.vuepress/dist

# Serverless directories
.serverless/

# FuseBox cache
.fusebox/

# DynamoDB Local files
.dynamodb/

# TernJS port file
.tern-port

# Stores VSCode versions used for testing VSCode extensions
.vscode-test

# yarn v2
.yarn/cache
.yarn/unplugged
.yarn/build-state.yml
.yarn/install-state.gz
.pnp.*

### Sass ###
.sass-cache/
*.css.map
*.sass.map
*.scss.map

### VisualStudioCode ###
.vscode/*
!.vscode/settings.json
!.vscode/tasks.json
!.vscode/launch.json
!.vscode/extensions.json
*.code-workspace

# Local History for Visual Studio Code
.history/

### VisualStudioCode Patch ###
# Ignore all local history of files
.history
.ionide

### Windows ###
# Windows thumbnail cache files
Thumbs.db
Thumbs.db:encryptable
ehthumbs.db
ehthumbs_vista.db

# Dump file
*.stackdump

# Folder config file
[Dd]esktop.ini

# Recycle Bin used on file shares
$RECYCLE.BIN/

# Windows Installer files
*.cab
*.msi
*.msix
*.msm
*.msp

# Windows shortcuts
*.lnk

# End of https://www.toptal.com/developers/gitignore/api/windows,linux,macos,node,sass,visualstudiocode

*.zip
11 changes: 11 additions & 0 deletions .nova/Tasks/Run.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"actions" : {
"run" : {
"enabled" : true,
"script" : "sass --watch .\/"
}
},
"identifier" : "B980F861-6B28-4214-A80C-189821EAF3AC",
"openLogOnRun" : "start",
"persistent" : true
}
1 change: 0 additions & 1 deletion .ruby-gemset

This file was deleted.

118 changes: 118 additions & 0 deletions .stylelintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
module.exports = {
"extends": [
"stylelint-config-sass-guidelines",
],
rules: {
'scss/at-function-pattern': "^_?[a-z]+([a-z0-9-]+[a-z0-9]+)?$",
'scss/at-mixin-pattern': "^_?[a-z]+([a-z0-9-]+[a-z0-9]+)?$",
'scss/dollar-variable-pattern': "^_?[a-z0-9]+(-[a-z0-9]+)*(__[a-z0-9]+(-[a-z0-9]+)*)?(--[a-z0-9]+(-[a-z0-9]+)*)?$",
"at-rule-empty-line-before": [
"always", {
"except": [
"blockless-after-same-name-blockless",
"first-nested"
],
"ignore": [
"after-comment"
],
"ignoreAtRules": [
"else",
"forward",
"use"
]
}
],
"order/properties-alphabetical-order": null,
"selector-pseudo-element-case": "lower",
"color-hex-case": "lower",
"color-hex-length": "long",
"at-rule-name-space-after": "always",
"at-rule-no-vendor-prefix": true,
"at-rule-semicolon-space-before": "never",
"block-closing-brace-empty-line-before": null,
"block-closing-brace-newline-after": null,
"block-opening-brace-space-before": "always",
"block-opening-brace-space-after": "never-single-line",
"block-no-empty": null,
"color-named": "never",
"declaration-colon-space-before": "never",
"declaration-colon-space-after": "always",
"selector-combinator-space-after": "always",
"declaration-block-semicolon-newline-after": "always-multi-line",
"declaration-block-semicolon-newline-before": "never-multi-line",
"declaration-block-semicolon-space-after": "always-single-line",
// "declaration-empty-line-before": [
// "always", {
// "except": [
// "first-nested",
// "after-comment",
// "after-declaration"
// ]
// }
// ],
"declaration-empty-line-before": null,
"declaration-no-important": true,
"font-family-name-quotes": "always-where-recommended",
"function-parentheses-space-inside": "never-single-line",
"function-url-no-scheme-relative": true,
"function-url-quotes": "always",
"length-zero-no-unit": true,
"max-empty-lines": 2,
"max-line-length": null,
// increasing max nesting because Sass-True already needs3
"max-nesting-depth": 4,
"media-feature-name-no-vendor-prefix": true,
"media-feature-parentheses-space-inside": "never",
"media-feature-range-operator-space-after": "always",
"media-feature-range-operator-space-before": "never",
"no-descending-specificity": null,
"no-duplicate-selectors": true,
"number-leading-zero": "always",
"property-no-vendor-prefix": true,
// "rule-empty-line-before": [
// "always", {
// "except": [
// "first-nested"
// ],
// "ignore": [
// "after-comment"
// ]
// }
// ],
"selector-attribute-quotes": "always",
"selector-class-pattern": [
"^_?[a-z0-9]+(-[a-z0-9]+)*(__[a-z0-9]+(-[a-z0-9]+)*)?(--[a-z0-9]+(-[a-z0-9]+)*)?$",
{
"message": "Class names should match the BEM naming convention"
}
],
"selector-list-comma-newline-after": "always",
"selector-list-comma-newline-before": "never-multi-line",
"selector-list-comma-space-after": "always-single-line",
"selector-list-comma-space-before": "never-single-line",
"declaration-colon-newline-after": null,
"selector-max-attribute": 2,
"selector-max-class": 4,
"selector-max-combinators": 4,
"selector-max-compound-selectors": 4,
"selector-max-empty-lines": 1,
"selector-max-id": 0,
"selector-max-specificity": null,
"selector-max-universal": 2,
"selector-no-qualifying-type": [
true,
{
"ignore": [
"attribute"
]
}
],
"selector-no-vendor-prefix": true,
"string-quotes": "single",
"value-keyword-case": "lower",
"value-list-comma-newline-after": "never-multi-line",
"value-list-comma-newline-before": "never-multi-line",
"value-list-comma-space-after": "always",
"value-no-vendor-prefix": true
}
};
3 changes: 0 additions & 3 deletions Gemfile

This file was deleted.

17 changes: 0 additions & 17 deletions bower.json

This file was deleted.

Loading