fix(runtime): ensured attributes are forwarded to createScript hook #2799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In NextJS, with a recent update to the nextjs-mf plugin, the app will immediately crash in the browser with "TypeError: Cannot convert undefined or null to object" because the
attrs
object is undefined in the next-internal-plugin createScript hook. It looks like there were a couple of places where onlyurl
was passed to the hook, and in those cases the runtime plugin bundled with nextjs-mf would fail when createScript was emitted.The error appears only to surface when using the manifest in NextJS, but I think the underlying issue is that
attrs
is expected by the hook but it isn't present when preloading.Related Issue
Steps to reproduce:
nextjs-ssr-manifest
example from this PR: feat(nextjs-mf): added nextjs-ssr-manifest example module-federation-examples#4231@module-federation/*
dependencies to their latest versions (as of now:nextjs-mf@8.4.4
,enhanced@0.3.1
)npm start
Types of changes
Checklist