fix(nextjs-mf): fix broken loading of non nextjs remotes #3323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6c8f932 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
6 tasks
the change to consume mf 2.0 manifests broke loading of non nextjs remotes because it was hard coded to assume next remotes.
h3adache
force-pushed
the
fix-nextjs-mf-remote-loading
branch
from
0a6bf5a to
7890299
Compare
|
@ScriptedAlchemy I know you aren't trying to pick up new nextjs-mf features but can you please look at this? It's blocking us atm as it breaks any non nextjs loading which I'm trying to migrate to. |
|
Will merge |
|
@h3adache please run |
ScriptedAlchemy
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change to consume mf 2.0 manifests broke loading of non nextjs remotes because it was hard coded to assume next remotes.
This change fixes loading of remotes while preserving the ability to load nextjs mf-manifests
Other minor changes are just to fix broken lint when running
Related Issue
Types of changes
Checklist