Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs-mf): add support for configuring externalRuntime and provideExternalRuntime #3439

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

OmarBERRABEH
Copy link

Added the ability to configure the nextjs-mf plugin to either use a provided runtime through the provideExternalRuntime option or leverage an external runtime via the externalRuntime configuration. This feature optimizes asset.

Description

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

…ideExternalRuntime

Added the ability to configure the nextjs-mf plugin to either use a provided runtime through the
provideExternalRuntime option or leverage an external runtime via the externalRuntime configuration.
This feature optimizes asset.
Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: a524027

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit a524027
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/678fda90265ce00008384787
😎 Deploy Preview https://deploy-preview-3439--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OmarBERRABEH
Copy link
Author

Hello @ScriptedAlchemy, is there a specific process for reviewing PRs?

@ScriptedAlchemy
Copy link
Member

@OmarBERRABEH try updating the next apps in the /apps directory and confirm that tests pass

@OmarBERRABEH
Copy link
Author

OmarBERRABEH commented Jan 22, 2025

@OmarBERRABEH try updating the next apps in the /apps directory and confirm that tests pass

@ScriptedAlchemy There is a circular dependency among all Next.js remotes in the /apps nextjs examples because sharedNav is provided by homeMFE and used by the others and HomeMFE consumes the other remotes. This prevents me from conducting a complete end-to-end test since there is no pure consumer. I see an options to resolve this add new example that includes a pure consumer.

it's okay for you ?

@ScriptedAlchemy
Copy link
Member

Do you have a repo to show me that it works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants