Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent destroy/render the remote component every time rerendering from the host #3479

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ducdv-lumin
Copy link

Description

Implement memoization for LazyComponent every time createRemoteComponent is called, so the remote component won't call the destroy/render method when the state changes from the host.

Related Issue

#3478

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: a2e87fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit a2e87fe
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/67a1a08054550a0008972620
😎 Deploy Preview https://deploy-preview-3479--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ducdv-lumin ducdv-lumin changed the title fix: prevent destroy/render remote component every time rerendering from host fix: prevent destroy/render the remote component every time rerendering from the host Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant