Merge pull request NixOS#163 from bhipple/feature/golang

Automated updates for buildGoModule packages

src/Nix.hs

@@ -8,6 +8,7 @@ module Nix
     assertOldVersionOn,
     build,
     cachix,
+    getAttr,
     getDerivationFile,
     getDescription,
     getDrvAttr,
@@ -117,6 +118,13 @@ getDrvAttr drvAttr =
   srcOrMain
     (\attrPath -> nixEvalET (EvalOptions Raw (Env [])) ("pkgs." <> attrPath <> ".drvAttrs." <> drvAttr))
 
+-- Get an attribute that can be evaluated off a derivation, as in:
+-- getAttr "cargoSha256" "ripgrep" -> 0lwz661rbm7kwkd6mallxym1pz8ynda5f03ynjfd16vrazy2dj21
+getAttr :: MonadIO m => Text -> Text -> ExceptT Text m Text
+getAttr attr =
+  srcOrMain
+    (\attrPath -> nixEvalET (EvalOptions Raw (Env [])) (attrPath <> "." <> attr))
+
 getHash :: MonadIO m => Text -> ExceptT Text m Text
 getHash =
   srcOrMain

src/Rewrite.hs

@@ -2,6 +2,7 @@
 
 module Rewrite
   ( Args (..),
+    golangModuleVersion,
     quotedUrls,
     rustCrateVersion,
     version,
@@ -93,7 +94,7 @@ rustCrateVersion log args@(Args _ attrPth drvFile drvContents) = do
       -- This starts the same way `version` does, minus the assert
       srcVersionFix args
       -- But then from there we need to do this a second time for the cargoSha256!
-      oldCargoSha256 <- Nix.getDrvAttr "cargoSha256" attrPth
+      oldCargoSha256 <- Nix.getAttr "cargoSha256" attrPth
       _ <- lift $ File.replace oldCargoSha256 Nix.sha256Zero drvFile
       newCargoSha256 <- Nix.getHashFromBuild attrPth
       when (oldCargoSha256 == newCargoSha256) $ throwE "cargoSha256 hashes equal; no update necessary"
@@ -104,6 +105,33 @@ rustCrateVersion log args@(Args _ attrPth drvFile drvContents) = do
       lift $ log "[rustCrateVersion] Finished updating Crate version and replacing hashes"
       return $ Just "Rust version update"
 
+--------------------------------------------------------------------------------
+-- Rewrite Golang packages with buildGoModule
+-- This is basically `version` above, but with a second pass to also update the
+-- modSha256 go vendor hash.
+golangModuleVersion :: MonadIO m => (Text -> m ()) -> Args -> ExceptT Text m (Maybe Text)
+golangModuleVersion log args@(Args _ attrPth drvFile drvContents) = do
+  lift $ log "[golangModuleVersion]"
+  if not (T.isInfixOf "buildGoModule" drvContents && T.isInfixOf "modSha256" drvContents)
+    then do
+      lift $ log "[golangModuleVersion] Not a buildGoModule package with modSha256"
+      return Nothing
+    else do
+      -- This starts the same way `version` does, minus the assert
+      srcVersionFix args
+      -- But then from there we need to do this a second time for the modSha256!
+      oldModSha256 <- Nix.getAttr "modSha256" attrPth
+      lift . log $ "[golangModuleVersion] Found old modSha256 = " <> oldModSha256
+      _ <- lift $ File.replace oldModSha256 Nix.sha256Zero drvFile
+      newModSha256 <- Nix.getHashFromBuild attrPth
+      when (oldModSha256 == newModSha256) $ throwE "modSha256 hashes equal; no update necessary"
+      lift . log $ "[golangModuleVersion] Replacing modSha256 with " <> newModSha256
+      _ <- lift $ File.replace Nix.sha256Zero newModSha256 drvFile
+      -- Ensure the package actually builds and passes its tests
+      Nix.build attrPth
+      lift $ log "[golangModuleVersion] Finished updating modSha256"
+      return $ Just "Golang update"
+
 --------------------------------------------------------------------------------
 -- Common helper functions and utilities
 -- Helper to update version and src attributes, re-computing the sha256.

src/Update.hs

@@ -217,8 +217,9 @@ updatePackage log updateEnv mergeBaseOutpathsContext =
     let rwArgs = Rewrite.Args updateEnv attrPath derivationFile derivationContents
     msg1 <- Rewrite.version log rwArgs
     msg2 <- Rewrite.rustCrateVersion log rwArgs
-    msg3 <- Rewrite.quotedUrls log rwArgs
-    let msgs = catMaybes [msg1, msg2, msg3]
+    msg3 <- Rewrite.golangModuleVersion log rwArgs
+    msg4 <- Rewrite.quotedUrls log rwArgs
+    let msgs = catMaybes [msg1, msg2, msg3, msg4]
     ----------------------------------------------------------------------------
     --
     -- Compute the diff and get updated values