if move site with phx then have bug and we are can't set default path

[Dmi3yy]

http://take.ms/RX1Vi

or if none phx file.

[modxuser]

I didn't realise that that was a bug

I had that each time I moved from localhost to live server, as the path to PHX was different. I always logged into the manager and reset the paths and all was then OK.

But, I no-longer use PHX so don't have that problem anymore LOL

[Dmi3yy]

its bug with new filter(phx in core) i too no more use PHx )) but someone use

…

-- Lukianenko Dmytro Web developer Site: http://dmi3yy.com Skype: dmi3yy Phone: +38 (091) 357-10-80 среда, 30 ноября 2016 г. в 16:28, modxuser написал:

I didn't realise that that was a bug I had that each time I moved from localhost to live server, as the path to PHX was different. I always logged into the manager and reset the paths and all was then OK. But, I no-longer use PHX so don't have that problem anymore LOL — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (#1017 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAo3M8x039pnCd3Ccq5K_cgzGzImbISDks5rDYfzgaJpZM4LAPac).

[MrSwed]

1. disable phx
2. correct paths
3. enable phx

[Dmi3yy]

1 need before move ) if гаеук you can do 2 step

…

-- Lukianenko Dmytro Web developer Site: http://dmi3yy.com Skype: dmi3yy Phone: +38 (091) 357-10-80 среда, 30 ноября 2016 г. в 16:36, Sergey Davydov написал:

disable phx correct paths enable phx — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (#1017 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAo3M00N_s8T3O4yR5_duvimW6S844htks5rDYn9gaJpZM4LAPac).

[MrSwed]

here
https://github.com/modxcms/evolution/blob/develop/manager/actions/mutate_settings/tab1_site_settings.inc.php#L137

need catch error..
or check path befor use any invoke events in configs

[MrSwed]

#623 (reference)

[yama]

if(is_file(MODX_BASE_PATH . 'assets/plugins/phx/phx.class.inc.php'))

maybe add this

[Dmi3yy]

yes

…

-- Lukianenko Dmytro Web developer Site: http://dmi3yy.com Skype: dmi3yy Phone: +38 (091) 357-10-80 понедельник, 5 декабря 2016 г. в 12:19, yamamoto написал:

if(is_file(MODX_BASE_PATH . 'assets/plugins/phx/phx.class.inc.php') maybe add this — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (#1017 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAo3M9VOA3UzX1H9ZLER_vf_N4ykE5D0ks5rE-UegaJpZM4LAPac).

[yama]

It should be same error on the front page, how is it?

[Dmi3yy]

if frontend no problem ) go setting and check MODX_BASE_PATH but when error in setting in first tab you cant fix MODX_BASE_PATH ) you see only first tab and error %)

…

-- Lukianenko Dmytro Web developer Site: http://dmi3yy.com Skype: dmi3yy Phone: +38 (091) 357-10-80 понедельник, 5 декабря 2016 г. в 12:28, yamamoto написал:

It should be same error on the front page, how is it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (#1017 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAo3M8o2BsIyr1IK4D89WjDO0o9P68lWks5rE-czgaJpZM4LAPac).

[yama]

hmm...? I do not know well, but it is certainly strange

[MrSwed]

I think I need a more accurate verification decision path in general, not specifically relating phx. If the check does not pass, first allow the user to adjust them, implying that the site has been moved

[Dmi3yy]

no strange i move site to another host but can’t set by default base_path in settings. I think this help http://take.ms/26Vxl

…

-- Lukianenko Dmytro Web developer Site: http://dmi3yy.com Skype: dmi3yy Phone: +38 (091) 357-10-80 понедельник, 5 декабря 2016 г. в 12:39, Sergey Davydov написал:

I think I need a more accurate verification decision path in general, not specifically relating phx. If the check does not pass, first allow the user to adjust them, implying that the site has been moved — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (#1017 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAo3M4CyGy_XjbXVDfEe1hoxj7j8cJXZks5rE-nNgaJpZM4LAPac).

[MrSwed]

@yama

if(is_file(MODX_BASE_PATH . 'assets/plugins/phx/phx.class.inc.php'))

no #623 (reference) was after two tryes, because phx can be renamed, including rename plugin files...

[MrSwed]

@Dmi3yy
there are is error occurs
$modx->invokeEvent('OnParseDocument')
before you test path to phx :)

[MrSwed]

something like (proposed logic)

if(!is_file(MODX_BASE_PATH . 'manager/include/config.inc.php')) {
 // promt to correct MODX_BASE_PATH
} else {
// existing output configuration.
}

?

[yama]

but can’t set by default base_path in settings.

hmm...?

[MrSwed]

@yama #1017 (comment)

[Deesen]

Or maybe replacing invokeEvent('OnParseDocument') with check for phx-plugincode and disabled != 1

// Check if PHX is enabled
$count = $modx->db->getRecordCount(
  $modx->db->select('id', $modx->getFullTableName('site_plugins'), 
  "plugincode LIKE '%phx.parser.class.inc.php%OnParseDocument();%' AND disabled != 1")
);

if($count) {
    $disabledFilters = 1;
    echo '<b>'.$_lang['enable_filter_phx_warning'].'</b><br/>';
}

[yama]

its better

[yama]

https://github.com/extras-evolution/PHx/blob/master/assets/plugins/phx/phx.plugin.txt#L15
The old version of PHx referred to "rb_base_dir". Is that problem?

[Deesen]

In my testing-case yes.

[yama]

ok, understood. I will fix this issue later

[yama]

// Check if PHX is enabled
$count = $modx->db->getRecordCount(
  $modx->db->select('id', $modx->getFullTableName('site_plugins'), 
  "plugincode LIKE '%phx.parser.class.inc.php%OnParseDocument();%' AND disabled != 1")
);

if($count) {
    $disabledFilters = 1;
    echo '<b>'.$_lang['enable_filter_phx_warning'].'</b><br/>';
}

I thought carefully, I think this fix is smarter.
I think that rb_base_dir issue needs to be solved as another problem.

[MrSwed]

may be better

"plugincode LIKE '%PHxParser%OnParseDocument();%' 

?

[Dmi3yy]

But this check not work with incorect base_parh. Need check file;) or still have bug Отправлено с iPhone

…

6 дек. 2016 г., в 08:57, Sergey Davydov ***@***.***> написал(а): may be better "plugincode LIKE '%PHxParser%OnParseDocument();%' ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[Deesen]

@Dmi3yy But what is you exact error-message? For me the error is

• invokeEvent onParseDocument
• this will eval() plugin-code of PHX
• plugincode starts with include_once ($modx->config['rb_base_dir']), not found
• calling $PHx->OnParseDocument() will cause fatal-error

So avoid invokeEvent should avoid any incorrect base-path at least for PHx? Or do other plugins cause problems OnParseDocument too?

[yama]

But this check not work with incorect base_parh

Is it "base_path"? not "rb_base_dir"?

[MrSwed]

updated phx has correct path
and I yesterday update site with old phx (rb_base_dir) - phx still work correctly

[Deesen]

Maybe this is a more global solution to check all kinds of plugins? #1060 (comment)

[dmitryy]

@Deesen please write correct @Dmi3yy not @dmitryy ;)

[Deesen]

Sry :-D

[MrSwed]

@Deesen
first - check correct path
second - check path fo each plugin befor run/invokeevent