Cached and nested snippets not working in EVO 1.2 #1089

vinelandit · 2016-12-09T14:51:34Z

a) Snippets called in [!snippetName!] format are not parsed, and just return the literal [[snippetName]] (replacing the [!!] brackets with [[]])

b) Nested snippets in alternating cached/uncached format, i.e. [!outerSnippet? &param='[[innerSnippet]]'!] are not parsed, and nested snippets using uncached format throughout throw a MySQL error.

(Backticks replaced with quotes in sample calls to avoid being marked up)

Example call:

[[Ditto? &documents='[[getVal? &docid='1' &field='featurePanel1']]' &tpl='homePanel' &extenders='summary' &truncLen='180' &truncOffset='90' ]]

Example error (similar error occurs when the inner snippet is called in uncached format, and the whole call unparsed and returned literally when the outer snippet is in uncached format):

« MODX Parse Error »
Execution of a query to the database failed - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '[[getVal?&docid=) AND sc.published=1 AND sc.deleted=0) AND (sc.privateweb=0) GRO' at line 1
SQL > SELECT DISTINCT sc.id FROM 'ajfadmin_modx'.'modx_site_content' sc LEFT JOIN 'ajfadmin_modx'.'modx_document_groups' dg on dg.document = sc.id WHERE (sc.id IN ([[getVal?&docid=) AND sc.published=1 AND sc.deleted=0) AND (sc.privateweb=0) GROUP BY sc.id
Error information
Current Snippet Ditto ... etc.

modxuser · 2016-12-09T16:14:49Z

I am not a back-end Dev, but the question arises - do your custom snippets still use deprecated MYSQL functions, as 1.2 supports MYSQLI

I have just checked my sites that have nested snippets, all of them work as expected. An example: I use "IF" in combination with Ditoo for IDs and other conditionals - all work perfectly OK

vinelandit · 2016-12-09T16:24:15Z

Hi modxuser, thanks for your reply. No, the custom snippets in question don't make any database calls.

Can you confirm that switching your cached [[Ditto? ... ]] call for a cached [!Ditto? ... !] call still works?

Deesen · 2016-12-09T18:07:43Z

[!Ditto!] still works for me testing the demo-page with blog, see screenshots. But inside ditto-tpl there is a uncached [!Jot!] which will be outputted for me like

modxuser · 2016-12-09T19:06:37Z

I have since updated my nested "IF" calls with the new built-in modifiers, but changing the Ditto snippet call from cached to uncached doesn't make any difference, it all still works.

yama · 2016-12-10T00:10:02Z

@vinelandit Thank you for your information, I will fix it later

always should be expand [!no-cache!] In the snippet call

#1089 (comment)

ref: #1089

Dmi3yy · 2016-12-13T13:32:15Z

http://take.ms/oPgO7

This all ok
http://take.ms/pi8zW

But if change to [[Ditto not work (((

need normal work:
[[ [[
[! [!
[[ [!
[! [[

yama · 2016-12-13T21:35:48Z

&year=`[[date_filter? &type=`year`]]`

This call will not work. Because it can not recognize the value nest. As with programming with PHP, you need to use different quotes.

&year="[[date_filter? &type='year']]"

&year='[[date_filter? &type="year"]]'

&year=`[[date_filter? &type="year"]]`

For example, write like these.
By changing the specification like this, it is now possible to include characters such as " = ? & ` " in the value.
But it may be improved further. I will think about it.

Dmi3yy · 2016-12-13T21:53:57Z

But all this work on 1.1 Its work from 1.0.9 or 1.0.8 And this big problem for update. Need or fixed or write what need do. Отправлено с iPhone

…

13 дек. 2016 г., в 23:35, yamamoto ***@***.***> написал(а): &year=`[[date_filter? &type=`year`]]` This call will not work. Because it can not recognize the value nest. As with programming with PHP, you need to use different quotes. &year="[[date_filter? &type='year']]" For example, write like this. By changing the specification like this, it is now possible to include characters such as " = ? & ` " in the value. But it may be improved further. I will think about it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

yama · 2016-12-13T23:49:56Z

ok, I will fix it later

#1089

Dmi3yy · 2016-12-14T12:19:02Z

with [[ [[ work

but with [! [! still not work

http://take.ms/SWPXS

but i newer used [! [!

i think now all ok and can close

MrSwed · 2016-12-15T12:58:52Z

@yama
after update get "Nesting level too deep"
Where, on the older version works without problems ..

10 is not too small?

upd. deleted (a wrong determination of the perpetrator .. looking for.. )

MrSwed · 2016-12-15T13:22:32Z

Founded:
Comment like

[[ [[AjaxSearch? &showResults=`0` &showInputForm=`1` &ajaxSearch=`0` &ajaxSearchType=`0` &extract =`0` &landingPage=`33` &moreResultsPage=`33` &liveSearch=`0` &extract=`1` &advSearch=`allwords` &maxWords=`10` &minChars=`10`]]
]]

not work more - give error "Nesting level too deep"

yama · 2016-12-15T13:37:09Z

10 is not too small?

It's possible, but it is maybe bug. Wait a moment.

yama · 2016-12-15T13:40:59Z

while($delim==='`' && substr(trim($_tmp),0,1)!=='&' && trim($_tmp)!=='' && 1<substr_count($_tmp,'`')) {
    list($inner, $outer, $_tmp) = explode('`', $_tmp, 3);
    $value .= "`{$inner}`{$outer}";
    $i++;
    if(10<$i) exit('Nesting level too deep');
}

maybe fix

MrSwed · 2016-12-15T13:46:53Z

it's kind of helped ..

MrSwed · 2016-12-15T13:50:44Z

immediately I do not quite understand this block, but in the call the snippet may be missing ` in values, and settings can be & and &

yama · 2016-12-15T22:46:36Z

[[ [[AjaxSearch? &showResults=`0` &showInputForm=`1` &ajaxSearch=`0` &ajaxSearchType=`0` &extract =`0` &landingPage=`33` &moreResultsPage=`33` &liveSearch=`0` &extract=`1` &advSearch=`allwords` &maxWords=`10` &minChars=`10`]]
]]

Question. How does this work? I thought it was a magical snippet call.

MrSwed · 2016-12-16T05:45:47Z

here is meant commented out
Of course you can not do so personally, I usually do something like
[[AjaxSearch-off ... ]]

yama · 2016-12-16T07:44:15Z

Comment out? That's an interesting idea.
ok, I will fix it later.

#1089 (comment) [[ string ]] it's error

yama · 2016-12-16T08:00:00Z

7a2d630
ok?

MrSwed · 2016-12-19T10:42:14Z

new trouble:

[[if? &is=`[*articles_ids*]:!empty`
&then=`
<!-- skipped -->
[[Ditto? &documents=`[*articles_ids*]` &tpl=`articlesTpl` &orderBy=`pub_date DESC,createdon desc` &paginate=`0` &display=`all`]]
<!-- skipped -->`
]]

after update MODX get "Illegal value of... "

If call ditto twice like phx ?
may be here (

evolution/assets/snippets/ditto/classes/ditto.class.inc.php

Line 595 in 21fabe6

if(!preg_match('@^[0-9, ]*$@',$IDs)) exit(sprintf('Illegal value of &documents: %s', $IDs));

)
be better somesthing like

  if(!preg_match('@^[0-9, ]*$@',$IDs))   return array();

yama · 2016-12-19T11:12:02Z

[[if? &is=`[*articles_ids*]:!empty`
    &then=`
        [[Ditto? &documents=`[*articles_ids*]` &orderBy=`editedon asc`]]
]]

Easily rewritten and tried it, but the problem did not happen. Are there other hints?

yama · 2016-12-19T11:19:26Z

[[if? &is=`[*articles_ids*]:!empty`
    &then=`[[Ditto? &documents=`[*articles_ids*]`]] `
]]

Does this reproduce the problem?

MrSwed · 2016-12-19T13:44:00Z

when I delete accidentally nonessential (skiped) deleted tilde
so that nothing significant has changed
below is full snipped

[[if? &is=`[*articles_ids*]:!empty`
&then=`
<div id="Obzori">
	<hr>
	<div class="items">
[[Ditto? &documents=`[*articles_ids*]` &tpl=`articlesTpl` &orderBy=`pub_date DESC,createdon desc` &paginate=`0` &display=`all`]]
	</div>
</div>
`
&else=`<div id="Obzori"></div>`
]]

the problem temporarily solved the method proposed above (return array() instead exit

yama · 2016-12-19T21:10:35Z

Is it related to the nesting of snippet calls?

MrSwed · 2016-12-20T07:08:14Z

I think yes, snippet [[If]] should not call nested Ditto, if the condition does not match

Deesen · 2016-12-20T07:21:37Z

But snippet-rendering works recursive from inside to outside, means "snippetIn" will always be rendered before snippetOut to provide a result (for example when using &param=[[ultimateParent]] you need a result first).

[[snippetOut? &param=`[[snippetIn]]`]]

To get around this &param must be able to accept a chunk with snippetIn inside, which will only get parsed by snippetOut if true.

[[if? &is=`1:is:1` &then=`@TPL:snippetIn_chunk`]]

MrSwed · 2016-12-20T08:25:24Z

I think in this case it is necessary to solve both ways

Fix Ditto
Fix nested calls

yama · 2016-12-20T10:19:11Z

evolution/manager/includes/document.parser.class.inc.php

Lines 932 to 937 in 90d3cdc

    
           foreach($tags as $tag) { 
        
               if(strpos($tag,$left)!==false) { 
        
                   $innerTags = $this->_getTagsFromContent($tag,$left,$right); 
        
                   $tags = array_merge($innerTags,$tags); 
        
               } 
        
           }

Maybe these lines are unnecessary. Because nest processing is done in $modx->getParamsFromString() .

yama · 2016-12-21T01:43:14Z

document.parser.class.inc.zip
Maybe fixed

#1089

yama · 2016-12-24T08:13:39Z

660163d
Fixed now. Since there are many repair lines, please test carefully.

yama · 2016-12-26T10:23:23Z

Found new nest pattern

[[if?
    &is=`1:not:2`
    &then='
        [[if? &is=`1:not:3` &then=`
            [[if? 
                &is=`1:is:4` 
                &then=`aaa`
                &else=`bbb`
            ]]
        `]]
    '
    &else=`ccc`
]]

Not work

Dmi3yy · 2016-12-26T10:26:37Z

test this: [[if? &is=`1:not:2` &then=` [[if? &is=`1:not:3` &then=` [[if? &is=`1:is:4` &then=`aaa` &else=`ccc` ]] `]] ` &else=`bbb` ]] От 26 декабря 2016 г. в 12:23:23, yamamoto (notifications@github.com) написал: [[if? &is=`1:not:2` &then=` [[if? &is=`1:not:3` &then=` [[if? &is=`1:is:4` &then=`aaa` ]] `]] ` &else=`bbb` ]]

yama · 2016-12-26T10:36:20Z

It's work.
But, remove "&else=`ccc`” will malfunction

Dmi3yy · 2016-12-26T10:37:13Z

if not use ccc. nothing to show ) От 26 декабря 2016 г. в 12:36:22, yamamoto (notifications@github.com) написал: It's work. But, remove "&else=`ccc`” will malfunction — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1089 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAo3M5teahS6Kvc47nvHYfREnUgi7wZmks5rL5ikgaJpZM4LJAxj> .

yama · 2016-12-26T10:39:50Z

In fact, a broken character string "aaa`]]`]] "is output. I think this is a malfunction of parser.

Deesen · 2017-01-01T13:22:43Z

What is the issue? For me it seems to be working correct. I get result "bbb" for

[[if?
	&is=`1:not:2`
	&then='
		[[if? &is=`1:not:3` &then=`
			[[if? 
				&is=`1:is:4` 
				&then=`aaa`
				&else=`bbb`
			]]
		`]]
	'
	&else=`ccc`
]]

Dmi3yy · 2017-03-13T11:46:48Z

before update
[[Ditto? &tpl=chunk]] and in chunk multiTV with @code. work correct
http://take.ms/PPvzI

after update to last version on git not work

yama · 2017-03-23T12:37:06Z

[[if?
    &is=`1:not:2`
    &then='
        [[if? &is=`1:not:3` &then=`
            [[if? 
                &is=`1:is:4` 
                &then=`aaa`
                &else=`bbb`
            ]]
        `]]
    '
    &else=`ccc`
]]

Is this a code that does not work?

Dmi3yy · 2017-03-23T12:54:53Z

Tested all ok
[!if? &is=1:not:2 &then=
[!if? &is=1:not:3
&then= [!if? &is=1:not:4 &then=
[!if? &is=1:is:4
&then=aaa
&else=yes
!] &else=bbb !]
!] &else=ccc`
!]

[[if? &is=1:not:2
&then= [[if? &is=1:not:3 &then=
[[if? &is=1:not:4
&then= [[if? &is=1:is:4 &then=aaa &else=yes ]]
&else=bbb
]] ]]
&else=ccc
]]

[!if? &is=1:not:2
&then= [[if? &is=1:not:3 &then=
[!if? &is=1:not:4
&then= [[if? &is=1:is:4 &then=aaa &else=yes ]]
&else=bbb
!] ]]
&else=ccc
!]

[[if? &is=1:not:2
&then= [!if? &is=1:not:3 &then=
[[if? &is=1:not:4
&then= [!if? &is=1:is:4 &then=aaa &else=yes !]
&else=bbb
]] !]
&else=ccc
]]

[[if? &is=1:not:2
&then= [!if? &is=1:not:3 &then=
[!if? &is=1:not:4
&then= [[if? &is=1:is:4 &then=aaa &else=yes ]]
&else=bbb
!] !]
&else=ccc
]]

[!if? &is=1:not:2
&then= [[if? &is=1:not:3 &then=
[[if? &is=1:not:4
&then= [!if? &is=1:is:4 &then=aaa &else=yes !]
&else=bbb
]] ]]
&else=ccc
!]
`
on old parser
yes
yes
yes
aaa
yes
aaa

on new parser

yes
yes
yes
yes
yes
yes

yama added a commit that referenced this issue Dec 10, 2016

#1089 F: Cached and nested snippets not working

7eaea30

always should be expand [!no-cache!] In the snippet call

yama added a commit that referenced this issue Dec 10, 2016

#1089 Ditto - Be sure to expand [!uncached!] in tpl-chunk

e39b9d6

#1089 (comment)

yama added a commit that referenced this issue Dec 10, 2016

Fix: Ditto - sql error of &documents parameter

21fabe6

ref: #1089

bossloper mentioned this issue Dec 13, 2016

parse Snippet not work with [[ [[ #1100

Closed

Dmi3yy added the 1.2.1 label Dec 13, 2016

yama added a commit that referenced this issue Dec 14, 2016

[F] #1089 Not work nested values in snippet call

3b0fe5f

#1089

Dmi3yy assigned yama Dec 14, 2016

Dmi3yy closed this as completed Dec 14, 2016

yama reopened this Dec 16, 2016

yama added a commit that referenced this issue Dec 16, 2016

[F] #1089 Issue of snippet call

7a2d630

#1089 (comment) [[ string ]] it's error

yama added a commit that referenced this issue Dec 24, 2016

[Fix] Issue of nesting tags

660163d

#1089

yama added a commit that referenced this issue Dec 24, 2016

[Fix] Empty placeholder parse issue

b691cfb

#1089

Dmi3yy added 1.2.2 and removed 1.2.1 labels Dec 26, 2016

Deesen mentioned this issue Jan 20, 2017

modx 1.2.0 update to 1.2.1 YAMS not working on frontend Deesen/YAMS#18

Closed

Dmi3yy closed this as completed Mar 23, 2017

Cached and nested snippets not working in EVO 1.2 #1089

Cached and nested snippets not working in EVO 1.2 #1089

Comments

vinelandit commented Dec 9, 2016

modxuser commented Dec 9, 2016

vinelandit commented Dec 9, 2016

Deesen commented Dec 9, 2016

modxuser commented Dec 9, 2016

yama commented Dec 10, 2016

Dmi3yy commented Dec 13, 2016

yama commented Dec 13, 2016 • edited Loading

Dmi3yy commented Dec 13, 2016 via email

yama commented Dec 13, 2016

Dmi3yy commented Dec 14, 2016

MrSwed commented Dec 15, 2016 • edited Loading

MrSwed commented Dec 15, 2016 • edited Loading

yama commented Dec 15, 2016

yama commented Dec 15, 2016

MrSwed commented Dec 15, 2016

MrSwed commented Dec 15, 2016

yama commented Dec 15, 2016

MrSwed commented Dec 16, 2016

yama commented Dec 16, 2016

yama commented Dec 16, 2016

MrSwed commented Dec 19, 2016

yama commented Dec 19, 2016 • edited Loading

yama commented Dec 19, 2016

MrSwed commented Dec 19, 2016

yama commented Dec 19, 2016

MrSwed commented Dec 20, 2016

Deesen commented Dec 20, 2016

MrSwed commented Dec 20, 2016

yama commented Dec 20, 2016

yama commented Dec 21, 2016

yama commented Dec 24, 2016

yama commented Dec 26, 2016 • edited Loading

Dmi3yy commented Dec 26, 2016 via email

yama commented Dec 26, 2016

Dmi3yy commented Dec 26, 2016 via email

yama commented Dec 26, 2016

Deesen commented Jan 1, 2017

Dmi3yy commented Mar 13, 2017

yama commented Mar 23, 2017

Dmi3yy commented Mar 23, 2017 • edited Loading

yama commented Dec 13, 2016 •

edited

Loading

MrSwed commented Dec 15, 2016 •

edited

Loading

MrSwed commented Dec 15, 2016 •

edited

Loading

yama commented Dec 19, 2016 •

edited

Loading

yama commented Dec 26, 2016 •

edited

Loading

Dmi3yy commented Mar 23, 2017 •

edited

Loading