Chunk with parameters drops placeholders defined before chunk

[pmfx]

Have issue with #625

Placeholders defined before chunk are missing inside this chunk when it have a parameter.

When I call chunk {{chunktest}}, [+before_chunk_placeholder+] inside chunk is OK and value is visible.

When I call chunk {{chunktest?&chunk_placeholder='Im chunk placeholder'}}, [+before_chunk_placeholder+] inside chunk is empty.

[Deesen]

Ok I can recreate that issue and will look into it.

[Deesen]

If I change 'hasModifier' to false both placeholders are working -> https://github.com/modxcms/evolution/blob/develop/manager/includes/document.parser.class.inc.php#L1044

@yama Is this a fix or does it break other functionality?

[Deesen]

@pmfx As stated in Slack I checked myself again and also with yama. It seems this issue is solved, I cannot recreate it using the same test-case as 1 month ago.

[yama]

inside chunk is OK and value is visible.

I can not understand this part well. "value is visible"?

[Deesen]

@pmfx Please correct me if I am wrong. My test-case for this issue:

Chunk "chunkph":

in chunk: [+chunk_placeholder+]
before chunk: [+before_chunk_placeholder+]

Snippet "setPlaceholder":

$modx->setPlaceholder($placeholder, $content);

Content of my test-resource:

[[setPlaceholder?&placeholder=`before_chunk_placeholder` &content=`this is content for ph before_chunk_placeholder`]]

chunk_placeholder is parsed, before_chunk_placeholder is NOT
{{chunkph?&chunk_placeholder=`chunk_placeholder`}}

chunkph - before_chunk_placeholder is parsed
{{chunkph}}

[yama]

It is not linked with setPlaceholder. I will improve it later.

[pmfx]

Just tested it and works great now. Thanks! Closing.