Skip to content
This repository has been archived by the owner on Mar 8, 2021. It is now read-only.

Correct the use one or more "RichText" on the page #559

Closed
wants to merge 1 commit into from

Conversation

Fess7
Copy link

@Fess7 Fess7 commented Mar 16, 2016

No description provided.

@Deesen
Copy link
Contributor

Deesen commented Mar 17, 2016

I tested and it will break the feature of using different themes in TV-options because rendering the config-object is not in the "foreach"-loop (that is what the define(editorkey_themekey)-functions are for). You find a screenshot of it at #548

And it will create now comma-separated list of elements for editors that can only handle single ids, so need to get instantiated one by one.

Enables only one theme:

config_tinymce4_mini['selector'] = '#ta,#tv18,#tv19,#tv14,#tv9';
tinymce.init(config_tinymce4_mini);

Throws error:

CKEDITOR.replace('tv15,tv17', config_ckeditor4_mini);
CKEDITOR.instances['tv15,tv17'].on('change', function () {
    if (CKEDITOR.instances['tv15,tv17'].checkDirty()) { documentDirty = true; }
});

What was your issue for that pull-request?

@Deesen
Copy link
Contributor

Deesen commented Mar 17, 2016

I know now what is the issue.... I switched TinyMCE4 to use config-objects but for some reason only the last get initialized... so the issue is with TinyMCE4 then -> extras-evolution/tinymce4-for-modx-evo#13

@Fess7
Copy link
Author

Fess7 commented Mar 17, 2016

You are right, it really breaks TV-options. Sorry)

@Fess7 Fess7 closed this Mar 17, 2016
@Deesen
Copy link
Contributor

Deesen commented Mar 17, 2016

But thanks for pointing out that stupid bug!

@Fess7
Copy link
Author

Fess7 commented Mar 17, 2016

Don't mention it!

@Deesen
Copy link
Contributor

Deesen commented Mar 17, 2016

Fixed it I hope.. if you like to check
extras-evolution/tinymce4-for-modx-evo#14
#558

@Fess7
Copy link
Author

Fess7 commented Mar 17, 2016

It is working now, thank you!

Dmi3yy pushed a commit that referenced this pull request Mar 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants