Only show resource types in template picker and context menus if the …

…user has permission to create them (#15893) Merge remote-tracking branch 'upstream/pr/16403' into 3.x * upstream/pr/16403: Update modResource derivatives
modxcms · Feb 10, 2024 · bca1927 · bca1927
2 parents 8c35dbf + 20ae2a6
commit bca1927
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 4 deletions.
diff --git a/core/docs/changelog.txt b/core/docs/changelog.txt
@@ -8,6 +8,7 @@ development release, and is only shown to give an idea of what's currently in th
 - Grid filtering via URL parameters added to most grids in the manager (#16089, #16369)
 - Store last opened media browser path in browser history / URL parameters to re-open last path (#16394)
 - Fix template picker to avoid errors in certain edge cases (#16400)
+- Only show resource types in template picker and context menus if the user has permission to create them (#15893)
 
 MODX Revolution 3.0.3-pl (January 17, 2023)
 ====================================

diff --git a/core/src/Revolution/modStaticResource.php b/core/src/Revolution/modStaticResource.php
@@ -27,7 +27,9 @@ public function __construct(xPDO $xpdo)
     {
         parent:: __construct($xpdo);
         $this->set('class_key', __CLASS__);
-        $this->showInContextMenu = true;
+        $canCreate = (bool)$this->xpdo->hasPermission('new_static_resource');
+        $this->allowListingInClassKeyDropdown = $canCreate;
+        $this->showInContextMenu = $canCreate;
     }
 
     /**

diff --git a/core/src/Revolution/modSymLink.php b/core/src/Revolution/modSymLink.php
@@ -20,7 +20,9 @@ public function __construct(xPDO $xpdo)
         parent:: __construct($xpdo);
         $this->set('type', 'reference');
         $this->set('class_key', __CLASS__);
-        $this->showInContextMenu = true;
+        $canCreate = (bool)$this->xpdo->hasPermission('new_symlink');
+        $this->allowListingInClassKeyDropdown = $canCreate;
+        $this->showInContextMenu = $canCreate;
     }
 
     /**

diff --git a/core/src/Revolution/modWebLink.php b/core/src/Revolution/modWebLink.php
@@ -20,7 +20,9 @@ public function __construct(xPDO $xpdo)
         parent:: __construct($xpdo);
         $this->set('type', 'reference');
         $this->set('class_key', __CLASS__);
-        $this->showInContextMenu = true;
+        $canCreate = (bool)$this->xpdo->hasPermission('new_weblink');
+        $this->allowListingInClassKeyDropdown = $canCreate;
+        $this->showInContextMenu = $canCreate;
     }
 
     /**

diff --git a/manager/assets/modext/modx.jsgrps-min.js b/manager/assets/modext/modx.jsgrps-min.js