Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable DKIM capabilities by default via settings #16396

Closed
krisznet opened this issue Feb 23, 2023 · 1 comment · Fixed by #16421
Closed

Enable DKIM capabilities by default via settings #16396

krisznet opened this issue Feb 23, 2023 · 1 comment · Fixed by #16421
Labels
feature Request about implementing a brand new function or possibility.

Comments

@krisznet
Copy link
Contributor

Feature request

Summary

Native DKIM capabilities in modMailer would be very useful. The functionality is already there but can't be used by default or with an extension like FormIt.

Why is it needed?

More and more companies moving to DKIM and also using 2-factor authentication for email accounts, so even secure SMTP is not an option for those. SPF record is often not enough to be able to deliver email reliably.

Suggested solution(s)

MODx uses PHPMailer which is capable of sending emails using DKIM, even modMail and modPHPMailer implementation are capable of using them. It can be used from a snippet but it can't be used with in-built functionality or with an extra like FormIt. So a simple solution would be adding those DKIM options to the settings and also modifying modMailer::getDefaultAttributes() function so it would utilise those settings.
@krisznet krisznet added the feature Request about implementing a brand new function or possibility. label Feb 23, 2023
@JoshuaLuckers
Copy link
Contributor

@krisznet sounds like a good improvement! We encourage you to submit a pull request (PR) with your proposed changes. Your contribution would greatly help in resolving the issue efficiently.

If you need any assistance with the process, feel free to ask for help. We are happy to guide you through creating a PR.

@krisznet krisznet mentioned this issue Apr 12, 2023
Merged
opengeek pushed a commit that referenced this issue May 29, 2024
@krisznet @JoshuaLuckers
Native DKIM capability for emails (#16421)
28b4032 
### What does it do?
Adding native DKIM capabilities to MODX without creating a custom email
script. After setting up the correct values in system settings, all mail
sent by MODx will be signed.

### Why is it needed?
More and more companies moving to DKIM and also using 2-factor
authentication for email accounts, so even secure SMTP is not an option
for those. SPF record is often not enough to be able to deliver email
reliably.

### How to test
Regular mail and SMTP should work like before. If you add DKIM details
in settings the Emailer should use it and the email should be signed
with the correct key.

### Related issue(s)/PR(s)
Resolves #16396

---------

Co-authored-by: Joshua Lückers - Jacobsen <joshualuckers@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Request about implementing a brand new function or possibility.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New: Native DKIM capability for emails krisznet/revolution
2 participants
@JoshuaLuckers @krisznet