Thumbnails not working in the media browser in PHP 7.4 #16468

DmitryFX · 2023-09-06T07:53:57Z

Bug report

Summary

Thumbnails not working in the media browser.

Step to reproduce

Upload any image (jpg, png) in the media browser, no thumbnails.

Observed behavior

Trying to navigate the url given in the 'not found' <img src='/site/connectors/system/phpthumb.php?src=assets%252Fvideo-iframe.png&w=100&h=0&HTTP_MODAUTH=modx64e51c266752a2.30117216_164f338950c1714.28557021&f=png&q=90&wctx=mgr&source=1&t=1693977472&ar=x'>
I get:

Fatal error: Uncaught TypeError: Argument 2 passed to phpthumb::__set() must be an instance of mixed, bool given in 

D:\site\site_www\core\vendor\james-heinrich\phpthumb\phpthumb.class.php:321 Stack trace: #0 

D:\site\site_www\core\vendor\james-heinrich\phpthumb\phpthumb.class.php(405): phpthumb->__set('cache_source_en...', false) #1 

D:\site\site_www\core\src\Revolution\modPhpThumb.php(100): phpthumb->setParameter('cache_source_en...', false) #2 

D:\site\site_www\core\src\Revolution\Processors\System\PhpThumb.php(140): MODX\Revolution\modPhpThumb->initialize() #3 

D:\site\site_www\core\src\Revolution\Processors\System\PhpThumb.php(84): MODX\Revolution\Processors\System\PhpThumb->loadPhpThumb() #4 

D:\site\site_www\core\src\Revolution\Processors\Processor.php(189): MODX\Revolution\Processors\System\PhpThumb->process() #5 

D:\site\site_www\core\src\Revolution\modX.php(1761): MOD in 

D:\site\site_www\core\vendor\james-heinrich\phpthumb\phpthumb.class.php on line 321

Error Log, set to Debug mode:

[2023-09-06 08:32:31] (DEBUG @ D:\site\site_www\core\src\Revolution\modLexicon.php : 526) Language string not found: "prop_file.skipExtensions_desc"
[2023-09-06 08:32:31] (DEBUG @ D:\site\site_www\core\src\Revolution\modLexicon.php : 526) Language string not found: "fred"
[2023-09-06 08:32:31] (DEBUG @ D:\site\site_www\core\src\Revolution\modLexicon.php : 526) Language string not found: "fredReadOnly"
[2023-09-06 08:32:31] (DEBUG @ D:\site\site_www\core\src\Revolution\modLexicon.php : 526) Language string not found: "prop_file.skipExtensions_desc"
[2023-09-06 08:32:31] (DEBUG @ D:\site\site_www\core\src\Revolution\modLexicon.php : 526) Language string not found: "fred"
[2023-09-06 08:32:31] (DEBUG @ D:\site\site_www\core\src\Revolution\modLexicon.php : 526) Language string not found: "fredReadOnly"
[2023-09-06 08:32:31] (DEBUG @ D:\site\site_www\core\src\Revolution\modLexicon.php : 526) Language string not found: "prop_file.skipExtensions_desc"
[2023-09-06 08:32:31] (DEBUG @ D:\site\site_www\core\src\Revolution\modLexicon.php : 526) Language string not found: "fred"
[2023-09-06 08:32:31] (DEBUG @ D:\site\site_www\core\src\Revolution\modLexicon.php : 526) Language string not found: "fredReadOnly"
[2023-09-06 08:32:31] (DEBUG @ D:\site\site_www\core\src\Revolution\modLexicon.php : 526) Language string not found: "prop_file.skipExtensions_desc"
[2023-09-06 08:32:31] (DEBUG @ D:\site\site_www\core\src\Revolution\modLexicon.php : 526) Language string not found: "fred"
[2023-09-06 08:32:31] (DEBUG @ D:\site\site_www\core\src\Revolution\modLexicon.php : 526) Language string not found: "fredReadOnly"
[2023-09-06 08:32:31] (WARN @ D:\site\site_www\core\vendor\james-heinrich\phpthumb\phpthumb.class.php : 314) PHP notice: Undefined variable: value
[2023-09-06 08:32:31] (WARN @ D:\site\site_www\core\vendor\james-heinrich\phpthumb\phpthumb.class.php : 314) PHP notice: Undefined variable: value

Expected behavior

Thumbnails should work.

Environment

3.1.0-dev
PHP 7.4.30
Apache 2.4
Mysql 5.7.17

ModX 2.8.4 works in the same environment as expected.

The text was updated successfully, but these errors were encountered:

halftrainedharry · 2023-09-06T13:12:03Z

It seems that there has been an update to the phpThumb library (that is used by MODX to create thumbnails) that is not compatible with PHP 7.4. But I believe this issue has to be fixed in phpThumb and not in MODX.

The problem is this pull request:
https://github.com/JamesHeinrich/phpThumb/pull/216/files

For a quick fix, you could either change the PHP version to at least 8.0, or delete the word mixed from the line here:
https://github.com/JamesHeinrich/phpThumb/blob/7ee966b38ddd7eb4d8091389aa514604710711c8/phpthumb.class.php#L317

DmitryFX · 2023-09-06T15:39:08Z

halftrainedharry's solution worked. Many thanks!
SVG previews still not working, but it is another story.

rthrash · 2023-09-06T15:56:36Z

SVGs maybe shouldn't try generating thumbnails and just be passed through w/o a thumbnail?

DmitryFX · 2023-09-06T15:59:51Z

SVGs maybe shouldn't try generating thumbnails and just be passed through w/o a thumbnail?

Agree, but it looks, that phpthumb tries to make the preview and gives the following errors:

[2023-09-06 15:54:08] (DEBUG @ D:\site\site_www\core\src\Revolution\Sources\modMediaSource.php : 2376) assets/settings.svg has a mime type of: image/svg
[2023-09-06 15:54:08] (WARN @ D:\site\site_www\core\src\Revolution\Sources\modMediaSource.php : 2300) PHP notice: Undefined variable: image
[2023-09-06 15:54:08] (WARN @ D:\site\site_www\core\src\Revolution\Sources\modMediaSource.php : 2300) PHP notice: Undefined variable: image
[2023-09-06 15:54:08] (WARN @ D:\site\site_www\core\src\Revolution\Sources\modMediaSource.php : 1961) PHP notice: Trying to access array offset on value of type bool
[2023-09-06 15:54:08] (WARN @ D:\site\site_www\core\src\Revolution\Sources\modMediaSource.php : 1962) PHP notice: Trying to access array offset on value of type bool

Interesting:
Accessing .svg file directly via phpthumb connector gives the proper svg document in the browser.

http://localhost/site/connectors/system/phpthumb.php?src=assets%252Fsettings.svg&w=100&h=0&HTTP_MODAUTH=modx64e51c266752a2.30117216_164f338950c1714.28557021&f=png&q=90&wctx=mgr&source=1&t=1693977472&ar=x

But in the media browser svg preview looks as follows:

<img src="" data-src="" loading="lazy" width="100" height="80" alt="settings.svg" title="settings.svg">

halftrainedharry · 2023-09-06T16:51:13Z

SVGs maybe shouldn't try generating thumbnails and just be passed through w/o a thumbnail?

This should already be implemented. There are exceptions in the code for SVGs:

revolution/core/src/Revolution/Sources/modMediaSource.php

Lines 2238 to 2246 in 8feb62f

    
           protected function buildManagerImagePreview($path, $ext, $width, $height, $bases, $properties = []) 
        
           { 
        
               $size = $this->getImageDimensions($path, $ext); 
        
               if (is_array($size) && $size['width'] > 0 && $size['height'] > 0) { 
        
                   if ($ext == 'svg') { 
        
                       $size['src'] = $bases['urlAbsolute'] . ltrim($path, DIRECTORY_SEPARATOR); 
        
                       return $size; 
        
                   }

When I test it, it seems to work correctly (at least in MODX 3.0.3-pl).

modxcommunity · 2023-10-01T15:17:40Z

This issue has been mentioned on MODX Community. There might be relevant details there:

https://community.modx.com/t/modx-2-8-6-php-7-4-breaks-thumbnails-in-the-manager/7100/1

rthrash · 2023-10-04T16:31:20Z

PR submitted to the upstream repo: JamesHeinrich/phpThumb#218

modxcommunity · 2023-12-20T08:37:04Z

This issue has been mentioned on MODX Community. There might be relevant details there:

https://community.modx.com/t/no-image-thumbnails-after-modx-3-upgrade/7353/2

### What does it do? Updates phpThumb to v1.7.22-202312071641 ### Why is it needed? Fixes the issue with thumbnails not being generated when running on PHP 7.4 (or earlier). ### How to test Make sure thumbnails are being generated in the media browser when running on PHP 7.4. ### Related issue(s)/PR(s) Resolves #16468 for the 2.x branch

dimasites · 2024-03-26T14:15:18Z

Hi @opengeek sorry to bug you on this one but it'd be epic to get a release out with this fix.

People (like me and many other) stiil get updates websites and catches thumbnail bugs! Community chat warming with reports, manual codefixes coming to the wild...

But v2.8.7 milestone is only 58% complete, may be we can flush it faster?

rthrash · 2024-03-26T14:18:05Z

Work is definitely happening @dimasites … some of the issues/PRs may not make the 2.8.7 release depending on testing and feedback, but the important phpThumb one definitely will.

opengeek · 2024-03-26T14:28:11Z

Hi @opengeek sorry to bug you on this one but it'd be epic to get a release out with this fix.

People (like me and many other) stiil get updates websites and catches thumbnail bugs! Community chat warming with reports, manual codefixes coming to the wild...

But v2.8.7 milestone is only 58% complete, may be we can flush it faster?

We will be releasing it very soon. I would not pay much attention to the milestones—issues and PRs tend to get assigned to them with little regard for reality.

dimasites · 2024-03-26T16:56:46Z

Thanks @opengeek and @rthrash for answers!

But for critical bugs please (it is only my point) lets make immidiate solutions! May be even hotfix-release with revert bad commit, because problems like this, make damage to friendliness and popularity of MODX.

I know about PHP 7.4 lifetime (yes, it is over), but we all knows: many and many MODX sites use PHP 7.4, much more then PHP8...

And I'll show you confirmation that it's critical.

See screenshots with stat, based on ~4.2k MODX Apps (components) install/upgrade/uninstall over last ~15 months (with only about 50% of Russian because its from MODX RSC data-source:

All additional screen for representation:

Based on this stats, we see over 95% MODX website's affected the bug, and even this stats not 100% accurate, even half of MODX users is overmuch

I think, we need (or must) to be more responsible with critical bug fixing! it is not security issue, but strog Developer UX issue...

P.S. I cant and dont want to make any pressure, but want stronly highlight problem!

Also i hope my examples and arguments were at least informative for you, thank you for your attention! And very thanks for working on such a wonderful project as MODX!

denius-dev · 2024-03-26T17:33:04Z

+1 for bump fixed version faster!

wintik1 · 2024-03-26T17:46:38Z

+2 for bump fixed version faster!
HELP!
I also faced this problem

ShevArtV · 2024-03-26T17:56:38Z

+1 for bump fixed version faster!

Arahort · 2024-04-09T14:49:42Z

Long time have this problem...

Oksana-png · 2024-04-09T15:56:05Z

+1 for bump fixed version faster!

biz87 · 2024-04-09T17:11:34Z

+1 for bump fixed version faster!

smg6511 · 2024-04-22T14:05:16Z

This issue is resolved with the vendor fix for phpthumb in both 2.8.7 and 3.0.5.

DmitryFX added the bug The issue in the code or project, which should be addressed. label Sep 6, 2023

rthrash modified the milestones: v3.0.4, v2.8.6 Sep 6, 2023

rthrash added the needs-backport Issues that need to be backported to the previous maintenance version. label Sep 6, 2023

opengeek modified the milestones: v3.0.4, v3.0.5 Oct 3, 2023

MaticSulc mentioned this issue Oct 4, 2023

Modx 3.0.4-pl issue with image upload #16483

Open

opengeek changed the title ~~Thumbnails not working in the media browser~~ Thumbnails not working in the media browser in PHP 7.4 Oct 4, 2023

halftrainedharry mentioned this issue Oct 25, 2023

pthumb.class.php not compliant with php < 8.x (use 'mixed' type in member function) #16491

Closed

opengeek mentioned this issue Dec 21, 2023

Update phpThumb to v1.7.22-202312071641 #16506

Merged

Ibochkarev closed this as completed Feb 28, 2024

Ibochkarev reopened this Feb 28, 2024

Jako mentioned this issue Mar 12, 2024

After updating MODX to 2.8.6-pl, AjaxUpload no longer seems to work Jako/AjaxUpload#67

Closed

opengeek modified the milestones: v3.0.5, v3.0.6 Apr 10, 2024

smg6511 closed this as completed Apr 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Thumbnails not working in the media browser in PHP 7.4 #16468

Thumbnails not working in the media browser in PHP 7.4 #16468

DmitryFX commented Sep 6, 2023 •

edited

Loading

halftrainedharry commented Sep 6, 2023

DmitryFX commented Sep 6, 2023 •

edited

Loading

rthrash commented Sep 6, 2023

DmitryFX commented Sep 6, 2023 •

edited

Loading

halftrainedharry commented Sep 6, 2023

modxcommunity commented Oct 1, 2023

rthrash commented Oct 4, 2023

modxcommunity commented Dec 20, 2023

dimasites commented Mar 26, 2024 •

edited

Loading

rthrash commented Mar 26, 2024

opengeek commented Mar 26, 2024

dimasites commented Mar 26, 2024 •

edited

Loading

denius-dev commented Mar 26, 2024

wintik1 commented Mar 26, 2024

ShevArtV commented Mar 26, 2024

Arahort commented Apr 9, 2024

Oksana-png commented Apr 9, 2024 •

edited

Loading

biz87 commented Apr 9, 2024

smg6511 commented Apr 22, 2024

Thumbnails not working in the media browser in PHP 7.4 #16468

Thumbnails not working in the media browser in PHP 7.4 #16468

Comments

DmitryFX commented Sep 6, 2023 • edited Loading

Bug report

Summary

Step to reproduce

Observed behavior

Expected behavior

Environment

halftrainedharry commented Sep 6, 2023

DmitryFX commented Sep 6, 2023 • edited Loading

rthrash commented Sep 6, 2023

DmitryFX commented Sep 6, 2023 • edited Loading

halftrainedharry commented Sep 6, 2023

modxcommunity commented Oct 1, 2023

rthrash commented Oct 4, 2023

modxcommunity commented Dec 20, 2023

dimasites commented Mar 26, 2024 • edited Loading

rthrash commented Mar 26, 2024

opengeek commented Mar 26, 2024

dimasites commented Mar 26, 2024 • edited Loading

denius-dev commented Mar 26, 2024

wintik1 commented Mar 26, 2024

ShevArtV commented Mar 26, 2024

Arahort commented Apr 9, 2024

Oksana-png commented Apr 9, 2024 • edited Loading

biz87 commented Apr 9, 2024

smg6511 commented Apr 22, 2024

DmitryFX commented Sep 6, 2023 •

edited

Loading

DmitryFX commented Sep 6, 2023 •

edited

Loading

DmitryFX commented Sep 6, 2023 •

edited

Loading

dimasites commented Mar 26, 2024 •

edited

Loading

dimasites commented Mar 26, 2024 •

edited

Loading

Oksana-png commented Apr 9, 2024 •

edited

Loading